From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szaib-0005Bw-QX for qemu-devel@nongnu.org; Thu, 09 Aug 2012 17:56:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Szaia-0008HJ-BE for qemu-devel@nongnu.org; Thu, 09 Aug 2012 17:56:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szaia-0008Gw-2l for qemu-devel@nongnu.org; Thu, 09 Aug 2012 17:56:36 -0400 Message-ID: <50243202.2040600@redhat.com> Date: Thu, 09 Aug 2012 15:56:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343911554-11109-1-git-send-email-peter.maydell@linaro.org> <878vdvvha8.fsf@codemonkey.ws> <20120809192553.GA2603@otherpad.lan.raisama.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0E47C5CC125697486D8D5398" Subject: Re: [Qemu-devel] [PATCH v3] Support 'help' as a synonym for '?' in command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , Eduardo Habkost , patches@linaro.org, Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0E47C5CC125697486D8D5398 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/09/2012 03:02 PM, Peter Maydell wrote: > On 9 August 2012 20:25, Eduardo Habkost wrote: >> On Fri, Aug 03, 2012 at 03:42:39PM -0500, Anthony Liguori wrote: >>> Peter Maydell writes: >>>> For command line options which permit '?' meaning 'please list the >>>> permitted values', add support for 'help' as a synonym, by abstracti= ng >>>> the check out into a helper function. >=20 >>> Applied. Thanks. >> >> I just found out that this patch broke "-cpu ?dump", "-cpu ?cpuid", an= d >> "-cpu ?model": >=20 > These options appear to be completely undocumented. They're also pretty= > ugly syntax and seem to be x86 specific. Thankfully, libvirt is not using them. If there is a reason for libvirt to start using them, then libvirt would rather go through QMP than any new syntax when talking to newer qemu (that is, I'm okay if we completely lose the spelling as long as we don't lose the feature). >=20 > Any suggestions for what the sane syntax for these options would be? > (ie the analogous change to having '?' go to 'help'). -cpu help=3Ddump -cpu help=3Dcpuid --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0E47C5CC125697486D8D5398 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQJDIHAAoJEKeha0olJ0NqzU4H/3ToOxy1LZ26JQYKpJ3WPBGi VQfq1txDCrM8gA5Z3dXg2OreZLTkIvx/DaVoyb26mAG8yTqFTDBqx5YSnNMCG1aD ahzYusmXGl4dCMLWS1UrGz2kRRG30m2dQl8lyOAnmyq+FWjTkBiy/q+alsrOf5FC uzbJIyrUvngxIXMigZLOQS/tjZPDBf1KuDH8v53rJ14MqRWepSbdjg5WyT3swK0k KgeClh5q8D2uXbNPCbXktUl/2+5yfE18U1+EPtaS5yz+lyYiRdPwBeJA88zeDl8G oxy4EV4DztHbWVv7it+0UuZliaLBCrUdhebRGf/cf0Wj+H5DLbHZMD/eMS1/vDI= =DW9B -----END PGP SIGNATURE----- --------------enig0E47C5CC125697486D8D5398--