From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzkyY-0004qC-7d for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzkyW-0004gF-29 for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:53:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53859 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzkyV-0004gB-RW for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:53:43 -0400 Message-ID: <5024CC13.90507@suse.de> Date: Fri, 10 Aug 2012 10:53:39 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1344562055-7347-1-git-send-email-peter.crosthwaite@petalogix.com> In-Reply-To: <1344562055-7347-1-git-send-email-peter.crosthwaite@petalogix.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] armv7m: Guard against no -kernel argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" , peter.maydell@linaro.org Cc: paul@codesourcery.com, qemu-devel@nongnu.org, armbru@redhat.com Am 10.08.2012 03:27, schrieb Peter A. G. Crosthwaite: > A -kernel argument must be specified for this machine. Gaurd against no= -kernel "Guard" > argument. Previously gave an unhelpful "bad address" error message. >=20 > Signed-off-by: Peter A. G. Crosthwaite Otherwise looks good - PMM, can you fix? /-F > --- > hw/armv7m.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/armv7m.c b/hw/armv7m.c > index 8cec78d..9f66667 100644 > --- a/hw/armv7m.c > +++ b/hw/armv7m.c > @@ -227,6 +227,11 @@ qemu_irq *armv7m_init(MemoryRegion *address_space_= mem, > big_endian =3D 0; > #endif > =20 > + if (!kernel_filename) { > + fprintf(stderr, "Guest image must be specified (using -kernel)= \n"); > + exit(1); > + } > + > image_size =3D load_elf(kernel_filename, NULL, NULL, &entry, &lowa= ddr, > NULL, big_endian, ELF_MACHINE, 1); > if (image_size < 0) { >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg