From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>,
pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces
Date: Fri, 10 Aug 2012 11:15:29 +0200 [thread overview]
Message-ID: <5024D131.5090702@suse.de> (raw)
In-Reply-To: <1344568571-11755-2-git-send-email-peter.crosthwaite@petalogix.com>
Am 10.08.2012 05:16, schrieb Peter A. G. Crosthwaite:
> From: Anthony Liguori <aliguori@us.ibm.com>
>
> The current implementation of Interfaces is poorly designed. Each interface
> that an object implements ends up being an object that's tracked by the
> implementing object. There's all sorts of gymnastics to deal with casting
> between these objects.
>
> But an interface shouldn't be associated with an Object. Interfaces are global
> to a class. This patch moves all Interface knowledge to ObjectClass eliminating
> the relationship between Object and Interfaces.
>
> Interfaces are now abstract (as they should be) but this is okay. Interfaces
> essentially act as additional parents for the classes and are treated as such.
>
> With this new implementation, we should fully support derived interfaces
> including reimplementing an inherited interface.
>
> PC: Rebased against qom-next merge Jun-2012.
>
> PC: Removed replication of cast logic for interfaces, i.e. there is only
> one cast function - object_dynamic_cast() (and object_dynamic_cast_assert())
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Anthony, didn't you have a whole series to refactor interfaces and add
test cases?
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-10 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 3:16 [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-08-10 3:16 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-10 9:15 ` Andreas Färber [this message]
2012-08-10 10:43 ` Peter Crosthwaite
2012-08-10 3:16 ` [Qemu-devel] [PATCH 2/2] xilinx_axi*: Re-implemented interconnect Peter A. G. Crosthwaite
2012-08-13 9:41 ` [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Edgar E. Iglesias
2012-08-13 16:50 ` Andreas Färber
2012-08-13 17:58 ` Edgar E. Iglesias
-- strict thread matches above, loose matches on Subject: below --
2012-08-10 2:30 Peter A. G. Crosthwaite
2012-08-10 2:30 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-06 3:07 [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-08-06 3:07 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-07 23:46 ` Peter Crosthwaite
2012-08-08 7:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5024D131.5090702@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).