From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzpcR-00080B-Ja for qemu-devel@nongnu.org; Fri, 10 Aug 2012 09:51:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzpcP-0000Sa-Pj for qemu-devel@nongnu.org; Fri, 10 Aug 2012 09:51:15 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:40281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzpcP-0000S9-LG for qemu-devel@nongnu.org; Fri, 10 Aug 2012 09:51:13 -0400 Received: by yenm4 with SMTP id m4so1493179yen.4 for ; Fri, 10 Aug 2012 06:51:13 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <502511CB.40504@redhat.com> Date: Fri, 10 Aug 2012 15:51:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344605205-28583-1-git-send-email-kraxel@redhat.com> <1344605205-28583-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1344605205-28583-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] scsi: fix warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Il 10/08/2012 15:26, Gerd Hoffmann ha scritto: > hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this > function > > Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5) > are not clever enougth to figure, so sprinkle in a default: line to make > them happy. > > Signed-off-by: Gerd Hoffmann > --- > hw/scsi-bus.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index b8a857d..4981a02 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -761,6 +761,7 @@ static int ata_passthrough_12_xfer_size(SCSIDevice *dev, uint8_t *buf) > switch (length) { > case 0: > case 3: /* USB-specific. */ > + default: > xfer = 0; > break; > case 1: > @@ -784,6 +785,7 @@ static int ata_passthrough_16_xfer_size(SCSIDevice *dev, uint8_t *buf) > switch (length) { > case 0: > case 3: /* USB-specific. */ > + default: > xfer = 0; > break; > case 1: > Acked-by: Paolo Bonzini Paolo