From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0p35-0005QE-Js for qemu-devel@nongnu.org; Mon, 13 Aug 2012 03:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0p31-0007vw-7F for qemu-devel@nongnu.org; Mon, 13 Aug 2012 03:26:51 -0400 Message-ID: <5028AC2E.9060807@redhat.com> Date: Mon, 13 Aug 2012 09:26:38 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1344720275-26744-1-git-send-email-peter.maydell@linaro.org> <50278638.4070206@msgid.tls.msk.ru> In-Reply-To: <50278638.4070206@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org, patches@linaro.org Am 12.08.2012 12:32, schrieb Michael Tokarev: > On 12.08.2012 01:24, Peter Maydell wrote: >> POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero >> msg.msg_iovlen (in particular the MacOS X implementation will do this). >> Handle the case where iov_send_recv() is passed a zero byte count >> explicitly, to avoid accidentally depending on the OS to treat zero >> msg_iovlen as a no-op. >> >> Signed-off-by: Peter Maydell >> --- >> This is what was causing 'make check' to fail on MacOS X. >> The other option was to declare that a zero bytecount was illegal, I guess. > > Acked-by: Michael Tokarev > > Kevin, does this fix the test-iov failure you're seeing on one of > the build bots? It's not on a build bot but on my test machine, but yes, this does fix it indeed. Thanks for looking into it, Peter! Kevin