From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0qUt-0004Xl-IE for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0qUr-0003An-Cl for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:59:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0qUr-0003Af-4Z for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:59:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7D8xaVR025534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 04:59:36 -0400 Message-ID: <5028C239.9030801@redhat.com> Date: Mon, 13 Aug 2012 12:00:41 +0300 From: Yonit Halperin MIME-Version: 1.0 References: <1344846752-3485-1-git-send-email-cfergeau@redhat.com> In-Reply-To: <1344846752-3485-1-git-send-email-cfergeau@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org, Gerd Hoffmann Ack On 08/13/2012 11:32 AM, Christophe Fergeau wrote: > When parsing its command line parameters, spice aborts when it > finds unexpected values, except for the 'streaming-video' option. > This happens because the parsing of the parameters for this option > is done using the 'name2enum' helper, which does not error out > on unknown values. Using the 'parse_name' helper makes sure we > error out in this case. Looking at git history, the use of > 'name2enum' instead of 'parse_name' seems to have been an oversight, > so let's change to that now. > > Fixes rhbz#831708 > --- > ui/spice-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 4fc48f8..bb4f585 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -344,7 +344,8 @@ static const char *stream_video_names[] = { > [ SPICE_STREAM_VIDEO_FILTER ] = "filter", > }; > #define parse_stream_video(_name) \ > - name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names)) > + parse_name(_name, "stream video control", \ > + stream_video_names, ARRAY_SIZE(stream_video_names)) > > static const char *compression_names[] = { > [ SPICE_IMAGE_COMPRESS_OFF ] = "off",