From: Eric Blake <eblake@redhat.com>
Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration
Date: Mon, 13 Aug 2012 09:03:50 -0600 [thread overview]
Message-ID: <50291756.7090101@redhat.com> (raw)
In-Reply-To: <50291708.1090108@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On 08/13/2012 09:02 AM, Eric Blake wrote:
> On 08/13/2012 04:50 AM, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> hmp.c | 4 ++++
>> migration.c | 5 ++++-
>> migration.h | 1 +
>> qapi-schema.json | 6 +++++-
>> 4 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/hmp.c b/hmp.c
>> index c0b0a10..10fee1b 100644
>> --- a/hmp.c
>> +++ b/hmp.c
>> @@ -151,6 +151,10 @@ void hmp_info_migrate(Monitor *mon)
>> monitor_printf(mon, "Migration status: %s\n", info->status);
>> monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
>> info->total_time);
>> + if (strcmp(info->status, "completed") == 0) {
>> + monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n",
>> + info->downtime);
>> + }
>
> Very nice stat - useful at showing how 'live' a live migration really is.
>
Hit send too soon:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-08-13 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 10:50 [Qemu-devel] [RFC 0/7] Migration stats Juan Quintela
2012-08-13 10:50 ` [Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info Juan Quintela
2012-08-13 14:32 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable Juan Quintela
2012-08-13 15:01 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration Juan Quintela
2012-08-13 15:02 ` Eric Blake
2012-08-13 15:03 ` Eric Blake [this message]
2012-08-13 19:36 ` Luiz Capitulino
2012-08-13 10:50 ` [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime Juan Quintela
2012-08-13 15:05 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 5/7] migration: export migration_get_current() Juan Quintela
2012-08-13 15:06 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate Juan Quintela
2012-08-13 15:08 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output Juan Quintela
2012-08-13 15:12 ` Eric Blake
2012-08-13 16:04 ` Juan Quintela
2012-08-13 16:49 ` Eric Blake
2012-08-13 14:59 ` [Qemu-devel] [RFC 0/7] Migration stats Eric Blake
2012-08-13 15:08 ` Juan Quintela
2012-08-13 15:14 ` Eric Blake
2012-08-13 19:47 ` Luiz Capitulino
2012-08-16 10:25 ` Qunfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50291756.7090101@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).