From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wBV-0008Q5-4W for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:04:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0wBL-0007vT-Ks for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:04:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wBL-0007vN-Bi for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:03:51 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DF3oql024997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 11:03:50 -0400 Message-ID: <50291756.7090101@redhat.com> Date: Mon, 13 Aug 2012 09:03:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344855057-32509-1-git-send-email-quintela@redhat.com> <1344855057-32509-4-git-send-email-quintela@redhat.com> <50291708.1090108@redhat.com> In-Reply-To: <50291708.1090108@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE7CF7AC42EAF3D0DB9648562" Subject: Re: [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE7CF7AC42EAF3D0DB9648562 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/13/2012 09:02 AM, Eric Blake wrote: > On 08/13/2012 04:50 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> hmp.c | 4 ++++ >> migration.c | 5 ++++- >> migration.h | 1 + >> qapi-schema.json | 6 +++++- >> 4 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/hmp.c b/hmp.c >> index c0b0a10..10fee1b 100644 >> --- a/hmp.c >> +++ b/hmp.c >> @@ -151,6 +151,10 @@ void hmp_info_migrate(Monitor *mon) >> monitor_printf(mon, "Migration status: %s\n", info->status); >> monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",= >> info->total_time); >> + if (strcmp(info->status, "completed") =3D=3D 0) { >> + monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n= ", >> + info->downtime); >> + } >=20 > Very nice stat - useful at showing how 'live' a live migration really i= s. >=20 Hit send too soon: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE7CF7AC42EAF3D0DB9648562 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQKRdWAAoJEKeha0olJ0NqYTMH/ib3hRtPw5ODL24JYigJr667 tCNbMSiE8vCBrLUQRf/KtkpAko4byIYBx3xZQopVuIKfX9pBdAV+oAtNcYC1E+ll 0JK1+zSL0/1Nc4q8kRPuRLjUCL+Ml83os+tqnBD4G93w/E8plFAo8hb8m57URodL 9I5Jy85XSwkjB2r4FKw2LI8eBmjIHcwt/azOdQi9BWFa+24vo3KZgIuA+y79wQol iXezdiDNivR82IWfkVI3dtytCRKnu/H1qsxMeAm7bE/OxzsJu1RXOSFyMP01i1Cl GJxz6Se0S7vscHvhbaqyJHF7dBiuJ0tav0J8NKAEhBznVcAMp9cZlnFeFMnvOYk= =w/vf -----END PGP SIGNATURE----- --------------enigE7CF7AC42EAF3D0DB9648562--