From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wFd-00034O-Kt for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0wFX-0000ta-Af for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:08:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wFX-0000tW-1S for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:08:11 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DF8Ad5012930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 11:08:10 -0400 Message-ID: <50291859.6060303@redhat.com> Date: Mon, 13 Aug 2012 09:08:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344855057-32509-1-git-send-email-quintela@redhat.com> <1344855057-32509-7-git-send-email-quintela@redhat.com> In-Reply-To: <1344855057-32509-7-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDC18D7EC4674FF64A2418A77" Subject: Re: [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDC18D7EC4674FF64A2418A77 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/13/2012 04:50 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > arch_init.c | 2 ++ > hmp.c | 4 ++++ > migration.c | 2 ++ > migration.h | 1 + > qapi-schema.json | 4 ++++ > 5 files changed, 13 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -322,6 +322,9 @@ > # @downtime: total downtime in milliseconds for the guest. > # (since 1.2) > # > +# @expected-downtime: expected downtime in milliseconds for the > +# guest in last walk of the dirty bitmap. (sincte 1.2) s/sincte/since/ Should this field be marked optional? That is, it makes sense to expose the field while migration is ongoing, but when reporting the stats after migration is complete, there is no longer any expected downtime. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDC18D7EC4674FF64A2418A77 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQKRhZAAoJEKeha0olJ0NqaEEH/RKFcNzp68IExfFI/x+f+dGy 5zdRmpia2VE4/7vHajN2fx6337DRhSi0gXAk0J1eGDNXyFLnk1dRutZOn6lM7emB dr1cg3JYEh2ZePlqB/qdKQY1YRhQ1mz2U4OJ55EPvY6q/WGdAT6710VGZnnQ26iF 8S6CCR2x4bfnS2au9TWvMW8KngDaw8Ub/pfM+ZTEn3jNu1uNJOAqI/Ji6HBbLPGT VHYCtTSDek+4hYkp+niY7u2D9jSZL5lKyRLMO26WENyNe8O3x5uxbfXADGGAnpL2 O5EkL6X1iksvzHB3KxQkG0Rws8HAqNP6suHVYLHlDpZOqaz+7FRRMYpBS+jU0/0= =nvxl -----END PGP SIGNATURE----- --------------enigDC18D7EC4674FF64A2418A77--