From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wJI-0004zU-Cf for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0wJH-000263-4s for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:12:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wJG-00025y-Ob for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:12:03 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DFC2wA015393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 11:12:02 -0400 Message-ID: <50291941.7020002@redhat.com> Date: Mon, 13 Aug 2012 09:12:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344855057-32509-1-git-send-email-quintela@redhat.com> <1344855057-32509-8-git-send-email-quintela@redhat.com> In-Reply-To: <1344855057-32509-8-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9EE5AEAAC3A8037CFC0DB3ED" Subject: Re: [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9EE5AEAAC3A8037CFC0DB3ED Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/13/2012 04:50 AM, Juan Quintela wrote: > For now this is a placeholder, real info will appear once the bitmap > changes in the migration thread series is integrated. >=20 > Signed-off-by: Juan Quintela > --- > hmp.c | 4 ++++ > migration.c | 2 ++ > migration.h | 1 + > qapi-schema.json | 6 +++++- > 4 files changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/hmp.c b/hmp.c > index fc75ec3..dd40631 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -174,6 +174,10 @@ void hmp_info_migrate(Monitor *mon) > info->ram->normal); > monitor_printf(mon, "normal bytes: %" PRIu64 " kbytes\n", > info->ram->normal_bytes >> 10); > + if (info->ram->dirty_pages_rate) { > + monitor_printf(mon, "dirty pages rate: %" PRIu64 " pagfes\= n", s/pagfes/pages/ > +++ b/qapi-schema.json > @@ -266,11 +266,15 @@ > # > # @normal-bytes : number of normal bytes sent (since 1.2) As long as you are touching here: s/ :/:/ > # > +# @dirty-pages-rate: number of pages dirtied by second by the > +# guest. (since 1.2) Inconsistent on whether we have a '.' prior to the (since 1.2) marking. Since HMP only prints this stat when it is non-zero, should this field be marked optional? Then again, once you have dirty page tracking, I suspect this would never be zero (or even showing an explicit zero would help detect stalls). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9EE5AEAAC3A8037CFC0DB3ED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQKRlBAAoJEKeha0olJ0NqNfMH/jJx4kpF5tT1FgqKD8W0vI50 c7rTu1mnTot7fAg2/Yofu/VvipibBCwDJTGHEBsepOnZs3WqQWyqFAkgM/Nds98g oADe4zH4dwCdgSnJHw0Jq81DCDaHjEF2w7vIFKnWqgMEmjuRVbfU2rFgVIPCQ3KP WEA6JPhP3jbgB1+jTF5K8dxTEqE08BRrPJbyOiRh9j/4mtbjdU0NmJyYYOeyJ8dQ I3gQz5E3o68dR3KgrVK5mJ3pTeH8nICiHm0skrrgmSJqW0d5IBnx4pxLHVLhzW+9 nzdw3IY2mXcSyVEcWQQjEqCPT7l4F0Wm2ByXyGa1Va4ADxWhSyjTo56s0lQB4J4= =dS/2 -----END PGP SIGNATURE----- --------------enig9EE5AEAAC3A8037CFC0DB3ED--