From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zxr-00041q-9F for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0zxm-0008Uk-Nd for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:06:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zxm-0008TM-FS for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:06:06 -0400 Message-ID: <5029501A.3070900@redhat.com> Date: Mon, 13 Aug 2012 21:06:02 +0200 From: Igor Mammedov MIME-Version: 1.0 References: <1344369413-9053-1-git-send-email-ehabkost@redhat.com> <1344369413-9053-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1344369413-9053-2-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 01/15] cpus.h: include cpu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Gleb Natapov , =?ISO-8859-1?Q?Andreas_F=E4rber?= On 08/07/2012 09:56 PM, Eduardo Habkost wrote: > Needed for the definition of fprint_function. > > This is not necessary right now, but it will be necessary if code that > doesn't include cpu-common.h includes cpus.h. could fprint_function declaration be moved somewhere else? A lot of headers include cpu-common.h just for the sake of these simple/independent declarations and forward declared structures pointers. Maybe these trivial cases could be moved in separate header qemu-common-trivial.h. It could replace cpu-common.h in most headers and would help to untangle circular deps between cpu-common.h and cpu.h and reduce complications when one tries to embed in cpu some Device/SysBusDevice as a child. > > Signed-off-by: Eduardo Habkost > --- > cpus.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cpus.h b/cpus.h > index 81bd817..061ff7f 100644 > --- a/cpus.h > +++ b/cpus.h > @@ -1,6 +1,8 @@ > #ifndef QEMU_CPUS_H > #define QEMU_CPUS_H > > +#include "qemu-common.h" > + > /* cpus.c */ > void qemu_init_cpu_loop(void); > void resume_all_vcpus(void); > -- Regards, Igor