From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T1FK6-0000OZ-63
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 07:30:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T1FK4-0003JV-V7
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 07:30:10 -0400
Received: from thoth.sbs.de ([192.35.17.2]:20577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T1FK4-0003Fu-LH
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 07:30:08 -0400
Message-ID: <502A36B8.20405@siemens.com>
Date: Tue, 14 Aug 2012 13:30:00 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <50082E7F.7030800@siemens.com> <5008980C.60809@codemonkey.ws>
	<alpine.LNX.2.00.1207200359280.6944@linmac>
	<50090269.7090604@web.de> <50090601.40800@web.de>
In-Reply-To: <50090601.40800@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] audio: Make pcspk card selectable again
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

On 2012-07-20 09:17, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per
> target. Therefore, statically built soundhw array in arch_init.c stopped
> including this card.
> 
> Work around this by re-adding this define to config-target.mak.
> Long-term, a dynamic creation of this soundhw list will be necessary.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  configure |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/configure b/configure
> index 106209a..77b5096 100755
> --- a/configure
> +++ b/configure
> @@ -3818,6 +3818,11 @@ if test "$target_bsd_user" = "yes" ; then
>    echo "CONFIG_BSD_USER=y" >> $config_target_mak
>  fi
>  
> +# the static way of configuring available audio cards requires this workaround
> +if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
> +  echo "CONFIG_PCSPK=y" >> $config_target_mak
> +fi
> +
>  # generate QEMU_CFLAGS/LDFLAGS for targets
>  
>  cflags=""
> 

Ping.

Sorry in case this arrives twice but the first ping didn't show up on
the list for me.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux