qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: blauwirbel@gmail.com, anthony@codemonkey.ws,
	qemu-devel@nongnu.org, gleb@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB
Date: Tue, 14 Aug 2012 15:42:04 +0300	[thread overview]
Message-ID: <502A479C.8080700@redhat.com> (raw)
In-Reply-To: <1344945535-2774-2-git-send-email-armbru@redhat.com>

On 08/14/2012 02:58 PM, Markus Armbruster wrote:
> Partial pages make little sense and don't work.  Ensure the RAM size
> is a multiple of any possible target's page size.
> 
> index d01256a..b411d45 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2708,11 +2708,13 @@ int main(int argc, char **argv, char **envp)
>                      fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
>                      exit(1);
>                  }
> -
>                  if (value != (uint64_t)(ram_addr_t)value) {
>                      fprintf(stderr, "qemu: ram size too large\n");
>                      exit(1);
>                  }
> +                if (value & 0x1fff) {
> +                    value = (value + 0x1fff) & ~0x1fff;
> +                }

value = QEMU_ALIGN_UP(value, 8192);


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-08-14 12:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 11:58 [Qemu-devel] [PATCH 0/2] Fix two bugs related to ram_size Markus Armbruster
2012-08-14 11:58 ` [Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB Markus Armbruster
2012-08-14 12:42   ` Avi Kivity [this message]
2012-08-14 12:55     ` Markus Armbruster
2012-08-14 11:58 ` [Qemu-devel] [PATCH 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB Markus Armbruster
2012-08-14 18:31   ` Blue Swirl
2012-08-15  8:23     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A479C.8080700@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).