From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1GRp-0007Hh-2F for qemu-devel@nongnu.org; Tue, 14 Aug 2012 08:42:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1GRn-0000yE-Fd for qemu-devel@nongnu.org; Tue, 14 Aug 2012 08:42:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1GRn-0000yA-7V for qemu-devel@nongnu.org; Tue, 14 Aug 2012 08:42:11 -0400 Message-ID: <502A479C.8080700@redhat.com> Date: Tue, 14 Aug 2012 15:42:04 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1344945535-2774-1-git-send-email-armbru@redhat.com> <1344945535-2774-2-git-send-email-armbru@redhat.com> In-Reply-To: <1344945535-2774-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: blauwirbel@gmail.com, anthony@codemonkey.ws, qemu-devel@nongnu.org, gleb@redhat.com On 08/14/2012 02:58 PM, Markus Armbruster wrote: > Partial pages make little sense and don't work. Ensure the RAM size > is a multiple of any possible target's page size. > > index d01256a..b411d45 100644 > --- a/vl.c > +++ b/vl.c > @@ -2708,11 +2708,13 @@ int main(int argc, char **argv, char **envp) > fprintf(stderr, "qemu: invalid ram size: %s\n", optarg); > exit(1); > } > - > if (value != (uint64_t)(ram_addr_t)value) { > fprintf(stderr, "qemu: ram size too large\n"); > exit(1); > } > + if (value & 0x1fff) { > + value = (value + 0x1fff) & ~0x1fff; > + } value = QEMU_ALIGN_UP(value, 8192); -- error compiling committee.c: too many arguments to function