qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Funny -m arguments can crash
Date: Tue, 14 Aug 2012 15:25:06 +0200	[thread overview]
Message-ID: <502A51B2.30509@siemens.com> (raw)
In-Reply-To: <502A4FA8.7040508@redhat.com>

On 2012-08-14 15:16, Avi Kivity wrote:
> On 08/14/2012 02:01 PM, Jan Kiszka wrote:
> 
>>>> We can also easily automatically disable it when there is insufficient
>>>> (<1MB) memory. Will post a patch.
>>>
>>> Would be nicer if it auto-disables itself, but don't know if the option
>>> ROM has access to the memory size.
>>
>> There is that global ram_size, also used by vmport. Not really nice but
>> no precedent.
> 
> I meant do the detection in the guest.  But don't respin the patch, it
> doesn't really matter and host-side works just as well.

We must not allow the guest to decide over this. Unless I'm
misinterpreting something, a malicious guest could still trigger this
patching (in non-existent RAM) and crash the host.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-08-14 13:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 11:49 [Qemu-devel] Funny -m arguments can crash Markus Armbruster
2012-07-27 19:00 ` Blue Swirl
2012-07-28  6:41   ` Markus Armbruster
2012-07-28  8:29     ` Blue Swirl
2012-07-30 12:56       ` Markus Armbruster
2012-07-30 15:05         ` Blue Swirl
2012-08-08  9:04           ` Markus Armbruster
2012-08-08  9:16             ` Peter Maydell
2012-08-08 10:02               ` Markus Armbruster
2012-08-08  9:48             ` Avi Kivity
2012-08-13 13:41               ` Markus Armbruster
2012-08-13 13:56                 ` Avi Kivity
2012-08-13 14:02                   ` Gleb Natapov
2012-08-13 14:04                     ` Avi Kivity
2012-08-13 14:10                       ` Gleb Natapov
2012-08-13 20:35                         ` Blue Swirl
2012-08-19 19:26                   ` Kevin O'Connor
2012-08-13 14:19                 ` Anthony Liguori
2012-08-13 14:46                   ` Markus Armbruster
2012-08-14  8:44                   ` Markus Armbruster
2012-08-14 10:20                     ` Avi Kivity
2012-08-14 10:44                       ` Jan Kiszka
2012-08-14 10:51                         ` Avi Kivity
2012-08-14 11:01                           ` Jan Kiszka
2012-08-14 13:16                             ` Avi Kivity
2012-08-14 13:25                               ` Jan Kiszka [this message]
2012-08-14 13:42                                 ` Avi Kivity
2012-08-14 11:12                       ` Markus Armbruster
2012-08-14 13:25                         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A51B2.30509@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).