From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Hrk-0004y6-9U for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1Hre-0004DD-DL for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:13:04 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:36401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Hre-0004D2-9E for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:12:58 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Aug 2012 10:12:55 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 9D728C902E9 for ; Tue, 14 Aug 2012 10:10:39 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7EEAZIU090370 for ; Tue, 14 Aug 2012 10:10:36 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7EEAUQJ015894 for ; Tue, 14 Aug 2012 10:10:31 -0400 Message-ID: <502A5C54.5020301@linux.vnet.ibm.com> Date: Tue, 14 Aug 2012 10:10:28 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1344866929-30456-1-git-send-email-coreyb@linux.vnet.ibm.com> <1344866929-30456-7-git-send-email-coreyb@linux.vnet.ibm.com> <502A3F99.10500@redhat.com> In-Reply-To: <502A3F99.10500@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 6/7] block: Enable qemu_open/close to work with fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, eblake@redhat.com On 08/14/2012 08:07 AM, Kevin Wolf wrote: > Am 13.08.2012 16:08, schrieb Corey Bryant: >> When qemu_open is passed a filename of the "/dev/fdset/nnn" >> format (where nnn is the fdset ID), an fd with matching access >> mode flags will be searched for within the specified monitor >> fd set. If the fd is found, a dup of the fd will be returned >> from qemu_open. >> >> Signed-off-by: Corey Bryant > >> cutils.c | 5 +++ >> monitor.c | 83 ++++++++++++++++++++++++++++++++++++++++++- >> monitor.h | 5 +++ >> osdep.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> qemu-common.h | 1 + >> qemu-tool.c | 20 +++++++++++ >> 6 files changed, 222 insertions(+), 1 deletion(-) > > This breaks the build of vscclient and the qtest cases, because osdep.c > has now a new dependency on the fdset monitor functions. The easy way to > fix it would be to squash the following in (linking vscclient and qtests > with qemu-tool.o). Any objections? > > Kevin > Sorry about that. Now I know to run make check. :) I don't have any objections to this fix. I ran my tests again with this and there weren't any problems. -- Regards, Corey