From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: aik@ozlabs.ru, Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported
Date: Tue, 14 Aug 2012 17:35:46 +0300 [thread overview]
Message-ID: <502A6242.8010708@redhat.com> (raw)
In-Reply-To: <1344922050.4683.231.camel@ul30vt.home>
On 08/14/2012 08:27 AM, Alex Williamson wrote:
>> >
>> > Do we need this level of control? Open question I'm just wondering every
>> > time a new feature gets added together with --disable/--enable
>> > switches.
>>
>> I don't think so--it's easy enough for an administrator to disable vfio
>> for a user.
>
> Ok, out voted. I'll remove. Thanks,
>
There is an advantage to --enable-blah in that it errors out if build
requirements are not satisfied, compared to silently disabling the
feature with a plain ./configure. This is important for distro builds
which can start to silently break features when we add a new build
requirement.
But it can be done later, possibly with a new --enable=vfio,kvm,... list
instead of individual features.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-14 14:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 5:18 [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2 Alex Williamson
2012-08-01 5:18 ` [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header Alex Williamson
2012-08-01 7:13 ` Jan Kiszka
2012-08-01 18:09 ` Alex Williamson
2012-08-02 9:02 ` Jan Kiszka
2012-08-02 16:37 ` Alex Williamson
2012-08-02 16:45 ` Jan Kiszka
2012-08-01 5:18 ` [Qemu-devel] [PATCH 2/3] vfio: vfio-pci device assignment driver Alex Williamson
2012-08-13 22:18 ` Anthony Liguori
2012-08-14 5:25 ` Alex Williamson
2012-08-14 7:12 ` Stefan Hajnoczi
2012-08-14 13:51 ` Alex Williamson
2012-08-14 15:53 ` Avi Kivity
2012-08-14 17:23 ` Alex Williamson
2012-08-15 8:56 ` Avi Kivity
2012-08-01 5:18 ` [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported Alex Williamson
2012-08-01 7:15 ` Jan Kiszka
2012-08-01 18:14 ` Alex Williamson
2012-08-01 19:40 ` Alex Williamson
2012-08-02 9:03 ` Jan Kiszka
2012-08-13 22:19 ` Anthony Liguori
2012-08-14 5:27 ` Alex Williamson
2012-08-14 14:35 ` Avi Kivity [this message]
2012-08-13 13:27 ` [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2 Anthony Liguori
2012-08-13 13:58 ` Avi Kivity
2012-08-13 14:04 ` Jan Kiszka
2012-08-13 19:31 ` Anthony Liguori
2012-08-14 7:19 ` Jan Kiszka
2012-08-14 14:42 ` Avi Kivity
2012-08-14 14:53 ` Cole Robinson
2012-08-14 15:04 ` Jan Kiszka
2012-08-14 15:28 ` Cole Robinson
2012-08-13 14:23 ` Alex Williamson
2012-08-13 15:48 ` Andreas Hartmann
2012-08-13 16:14 ` Alex Williamson
2012-08-13 16:36 ` Andreas Hartmann
2012-08-13 16:57 ` Alex Williamson
2012-08-13 18:32 ` Andreas Hartmann
2012-08-13 19:33 ` Anthony Liguori
2012-08-13 20:48 ` Blue Swirl
2012-08-13 20:56 ` Alex Williamson
2012-08-13 20:55 ` [Qemu-devel] VFIO: Call for reviewers (was Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2) Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A6242.8010708@redhat.com \
--to=avi@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).