From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1IYZ-00040b-7R for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:57:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1IYW-0004SV-S9 for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:57:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1IYW-0004SM-KC for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:57:16 -0400 Message-ID: <502A6749.3080902@redhat.com> Date: Tue, 14 Aug 2012 16:57:13 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1344926686-9197-1-git-send-email-s.priebe@profihost.ag> In-Reply-To: <1344926686-9197-1-git-send-email-s.priebe@profihost.ag> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: fix race between task completition and task abortion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe Cc: qemu-devel@nongnu.org Am 14.08.2012 08:44, schrieb Stefan Priebe: > From: spriebe > > --- > block/iscsi.c | 36 ++++++++++++++++++++---------------- > 1 files changed, 20 insertions(+), 16 deletions(-) It would be nice to have your full name and a valid email address in the From: line (needs an update of your git config) and a more detailed explanation of the problem that you're fixing. Having a Signed-off-by line, however, is absolutely required and the patch can't be merged without it. > > diff --git a/block/iscsi.c b/block/iscsi.c > index 12ca76d..257f97f 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -76,6 +76,10 @@ static void > iscsi_abort_task_cb(struct iscsi_context *iscsi, int status, void *command_data, > void *private_data) > { > + IscsiAIOCB *acb = (IscsiAIOCB *)private_data; > + > + scsi_free_scsi_task(acb->task); > + acb->task = NULL; Please use scripts/checkpatch.pl. qemu uses an indentation of four spaces, more coding style violations follow. Kevin