From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Wer-0005m9-L4 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 02:00:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1Weo-0005uI-Ir for qemu-devel@nongnu.org; Wed, 15 Aug 2012 02:00:45 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:59891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Wen-0005tq-Vy for qemu-devel@nongnu.org; Wed, 15 Aug 2012 02:00:42 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Aug 2012 11:30:36 +0530 Message-ID: <502B3AF5.8010201@linux.vnet.ibm.com> Date: Wed, 15 Aug 2012 14:00:21 +0800 From: Li Zhang MIME-Version: 1.0 References: <1344966575-25952-1-git-send-email-zhlcindy@linux.vnet.ibm.com> <1344966575-25952-2-git-send-email-zhlcindy@linux.vnet.ibm.com> <21561D9F-70C7-4DCB-86AD-6C844BA59981@suse.de> In-Reply-To: <21561D9F-70C7-4DCB-86AD-6C844BA59981@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on sPAPR platform. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , Li Zhang , "david@gibson.dropbear.id.au" On 2012年08月15日 02:09, Alexander Graf wrote: > > On 14.08.2012, at 19:49, Li Zhang wrote: > >> USB is enabled as default on sPAPR platform because it needs >> USB keyboard and USB mouse when VGA is enabled. >> >> This patch is to add USB controller on sPAPR platform. >> >> Signed-off-by: Li Zhang > This looks a lot better than the first version :). Thanks. :) > > Alex > >> --- >> hw/spapr.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/hw/spapr.c b/hw/spapr.c >> index 81c9343..b45401b 100644 >> --- a/hw/spapr.c >> +++ b/hw/spapr.c >> @@ -710,6 +710,11 @@ static void ppc_spapr_init(ram_addr_t ram_size, >> spapr_vscsi_create(spapr->vio_bus); >> } >> >> + if (usb_enabled(true)) { Would you help replace "true" as "spapr->has_graphics" as your patch? We think it should be better to set the default as true when spapr->has_graphics. How do you think? >> + pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus, >> + -1, "pci-ohci"); >> + } >> + >> if (rma_size < (MIN_RMA_SLOF << 20)) { >> fprintf(stderr, "qemu: pSeries SLOF firmware requires >= " >> "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF); >> -- >> 1.7.7.6 >> -- Li Zhang IBM China Linux Technology Centre