From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1bAV-0002ej-G8 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:49:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1bAU-0004Bb-Au for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:49:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1bAT-0004BQ-Uc for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:49:42 -0400 Message-ID: <502B7CA4.1040109@redhat.com> Date: Wed, 15 Aug 2012 12:40:36 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1344347073-7773-1-git-send-email-benoit@irqsave.net> <1344347073-7773-4-git-send-email-benoit@irqsave.net> <20120810174824.GB2033@irqsave.net> <5028AF8C.8090803@redhat.com> <20120814165651.GB2020@irqsave.net> In-Reply-To: <20120814165651.GB2020@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: =?ISO-8859-1?Q?Beno=EEt_Canet?= , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, Blue Swirl , anthony@codemonkey.ws, pbonzini@redhat.com, eblake@redhat.com, afaerber@suse.de Am 14.08.2012 18:56, schrieb Beno=EEt Canet: > Le Monday 13 Aug 2012 =E0 09:41:00 (+0200), Kevin Wolf a =E9crit : >> Am 10.08.2012 19:48, schrieb Beno=EEt Canet: >>> Le Tuesday 07 Aug 2012 =E0 20:30:09 (+0000), Blue Swirl a =E9crit : >>>> On Tue, Aug 7, 2012 at 1:44 PM, Beno=EEt Canet wrote: >>>>> Signed-off-by: Benoit Canet >>>>> --- >>>>> block/quorum.c | 62 ++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++ >>>>> 1 file changed, 62 insertions(+) >>>>> >>>>> diff --git a/block/quorum.c b/block/quorum.c >>>>> index e0405b6..de58ab8 100644 >>>>> --- a/block/quorum.c >>>>> +++ b/block/quorum.c >>>>> @@ -47,11 +47,73 @@ struct QuorumAIOCB { >>>>> int vote_ret; >>>>> }; >>>>> >>>>> +/* Valid quorum filenames look like >>>>> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image >>>> >>>> This syntax would mean that stacking for example curl or other netwo= rk >>>> paths would not be possible. How about comma as separator? >>> >>> I just tried comma but it fail because the qemu command line parsing >>> catch it believing that the string next to the coma is another "file=3D= " >>> like options. >>> >>> Is there any other separator we can use ? >> >> I would ignore that for now, or you can introduce your own escaping of >> colons. The real solution is, once again, -blockdev. >=20 > Is -blockdev related to BlockBackend ? BlockBackend is a prerequisite for it. One of the goals with -blockdev is to have not only a filename for bdrv_open from which you can parse options, but that you can get structured and driver-specific options. Kevin