From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1b4c-0000NE-6d for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1b4b-0002N7-8O for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:43:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1b4b-0002N1-0V for qemu-devel@nongnu.org; Wed, 15 Aug 2012 06:43:37 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7FAhaJN011308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Aug 2012 06:43:36 -0400 Message-ID: <502B7D56.8050006@redhat.com> Date: Wed, 15 Aug 2012 12:43:34 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <5023C014.2080407@redhat.com> <1344522080-28833-1-git-send-email-alevy@redhat.com> <502B5C7B.4020502@redhat.com> <20120815103227.GH17706@garlic.redhat.com> In-Reply-To: <20120815103227.GH17706@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, >> Or maybe just use >> >> #ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC >> #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC $whatever >> #endif > > I don't get this. You mean to have add > #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC bla > to spice-protocol? No, to qemu, so QXL_HAS_IO_MONITORS_CONFIG_ASYNC is available no matter what version spice-protocol is. cheers, Gerd