From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1T1cu1-0004aq-Tp
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 08:40:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1T1cu0-0003fU-DK
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 08:40:49 -0400
Message-ID: <502B98CC.4000309@web.de>
Date: Wed, 15 Aug 2012 14:40:44 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1344519084-21847-1-git-send-email-armbru@redhat.com>
	<1344519084-21847-21-git-send-email-armbru@redhat.com>
	<5023C745.9040907@web.de> <87d330ru8v.fsf@blackfin.pond.sub.org>
	<04C1EE4B-D92A-4AAA-B703-E78C4B6B1FD3@suse.de>
	<877gt0gww5.fsf@blackfin.pond.sub.org>
In-Reply-To: <877gt0gww5.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 20/23] ppc: Suppress unused default drives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 15.08.2012 14:30, schrieb Markus Armbruster:
> Alexander Graf <agraf@suse.de> writes:
> 
>> On 09.08.2012, at 16:54, Markus Armbruster <armbru@redhat.com> wrote:
>>
>>> Andreas Färber <andreas.faerber@web.de> writes:
>>>
>>>> Am 09.08.2012 15:31, schrieb Markus Armbruster:
>>>>> diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c
>>>>> index f2c6908..bcecc0a 100644
>>>>> --- a/hw/ppc_oldworld.c
>>>>> +++ b/hw/ppc_oldworld.c
>>>>> @@ -338,6 +338,8 @@ static QEMUMachine heathrow_machine = {
>>>>>     .desc = "Heathrow based PowerMAC",
>>>>>     .init = ppc_heathrow_init,
>>>>>     .max_cpus = MAX_CPUS,
>>>>> +    .no_floppy = 1,
>>>>> +    .no_sdcard = 1,
>>>>> #ifndef TARGET_PPC64
>>>>>     .is_default = 1,
>>>>> #endif
>>>>
>>>> Ack for SD.
>>>>
>>>> Not sure about the floppy. I thought the beige Old World machines used
>>>> to have a floppy with some incompatible Apple formatting... Did they use
>>>> a controller we don't implement? If so, then .no_floppy should get a
>>>> comment.
>>>
>>> I have no idea.  Alex?
>>
>> I'd have to check wikipedia all the same :)
> 
> All right, I did: they had some kind of floppy.  No clue what kind.
> 
> And we already have a comment:
> 
>             /* TOFIX: for now, the second IDE channel is not properly
>              *        used by OHW. The Mac floppy disk are not emulated.
>              *        For now, OHW cannot boot from the network.
>              */
> 
> Andreas, still want a comment next to .no_floppy?

Nah, no need then. :)

We should rather spend the time on getting OpenBIOS working with PReP...
o:-)

Andreas