From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in cpu.h
Date: Wed, 15 Aug 2012 17:11:30 +0200 [thread overview]
Message-ID: <502BBC22.9030205@suse.de> (raw)
In-Reply-To: <1344618044-18704-2-git-send-email-aliguori@us.ibm.com>
Am 10.08.2012 19:00, schrieb Anthony Liguori:
> Header file dependency is a frickin' nightmare right now. cpu.h tends to get
> included in our 'include everything' header files but qdev also needs to include
> those headers mainly for qdev-properties since it knows about CharDriverState
> and friends.
>
> We can solve this for now by splitting out qdev.h along the same lines that we
> previously split the C file. Then cpu.h just needs to include qdev-core.h
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Quickly looked through and qdev.h split looks fine.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-15 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:00 [Qemu-devel] [PATCH 0/2] cpu: make a child of DeviceState Anthony Liguori
2012-08-10 17:00 ` [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in cpu.h Anthony Liguori
2012-08-15 15:11 ` Andreas Färber [this message]
2012-08-10 17:00 ` [Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState Anthony Liguori
2012-08-10 17:09 ` Eduardo Habkost
2012-08-10 18:28 ` Anthony Liguori
2012-08-15 15:41 ` Andreas Färber
2012-08-15 16:29 ` Anthony Liguori
2012-08-15 15:50 ` [Qemu-devel] [PATCH 0/2] cpu: make " Andreas Färber
-- strict thread matches above, loose matches on Subject: below --
2012-06-22 19:36 [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in cpu.h Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BBC22.9030205@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).