From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1g5o-000858-RC for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1g5k-0001Ds-T0 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:05:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57855 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1g5k-0001Ci-Lo for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:05:08 -0400 Message-ID: <502BC8B0.8030509@suse.de> Date: Wed, 15 Aug 2012 18:05:04 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1344720880-26881-1-git-send-email-peter.maydell@linaro.org> <1344720880-26881-3-git-send-email-peter.maydell@linaro.org> <502BB667.5080009@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] Support using a different compiler for Objective-C files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Am 15.08.2012 16:55, schrieb Peter Maydell: > On 15 August 2012 15:47, Andreas F=C3=A4rber wrote: >> Am 11.08.2012 23:34, schrieb Peter Maydell: >>> +# Default objcc to clang if available, otherwise use CC >>> +if has clang; then >>> + objcc=3Dclang >> >> On IRC I had commented that I find defaulting to clang whenever clang = is >> available too aggressive (it may be some /usr/local/bin version that >> doesn't even have the right host architecture support compiled in). >> I won't object to this patch but would appreciate a follow-up limiting >> this to v10.8+ where it's actually needed and keep using gcc elsewhere= . >=20 > Mmm. It might be better to explicitly test for a compiler > with Blocks support (although even then you might end up > with clang on pre-10.8; I don't really want to check for "does > header Foo need blocks support" because that seems a bit fragile.) A simple does-clang-compile-a-hello-word-for-host check, falling back to gcc, should catch the worst regressions as well. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg