From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1giR-0006jX-W7 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1giQ-0004am-Gx for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:45:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59545 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1giQ-0004Ya-6Y for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:45:06 -0400 Message-ID: <502BD20B.7010506@suse.de> Date: Wed, 15 Aug 2012 18:44:59 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1345047221-26898-1-git-send-email-imammedo@redhat.com> <1345047221-26898-13-git-send-email-imammedo@redhat.com> In-Reply-To: <1345047221-26898-13-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 12/21] add visitor for parsing hz[KMG] input string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, vijaymohan.pandarathil@hp.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, ehabkost@redhat.com Am 15.08.2012 18:13, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > -- > v2: > * replaced _hz suffix for frequency visitor by _freq suffix > suggested-by: Andreas F=C3=A4rber > * fixed typo, spotted-by: Andreas F=C3=A4rber > --- > qapi/qapi-visit-core.c | 11 +++++++++++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-visitor.c | 22 ++++++++++++++++++++++ > 3 files changed, 35 insertions(+) >=20 > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index 7a82b63..5c8705e 100644 > --- a/qapi/qapi-visit-core.c > +++ b/qapi/qapi-visit-core.c > @@ -311,3 +311,14 @@ void input_type_enum(Visitor *v, int *obj, const c= har *strings[], > g_free(enum_str); > *obj =3D value; > } > + > +void visit_type_freq(Visitor *v, int64_t *obj, const char *name, Error= **errp) > +{ > + if (!error_is_set(errp)) { > + if (v->type_freq) { > + v->type_freq(v, obj, name, errp); > + } else { > + v->type_int(v, obj, name, errp); > + } > + } > +} > diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.h > index 60aceda..e5e7dd7 100644 > --- a/qapi/qapi-visit-core.h > +++ b/qapi/qapi-visit-core.h > @@ -62,6 +62,7 @@ struct Visitor > void (*type_int64)(Visitor *v, int64_t *obj, const char *name, Err= or **errp); > /* visit_type_size() falls back to (*type_uint64)() if type_size i= s unset */ > void (*type_size)(Visitor *v, uint64_t *obj, const char *name, Err= or **errp); > + void (*type_freq)(Visitor *v, int64_t *obj, const char *name, Erro= r **errp); > }; > =20 > void visit_start_handle(Visitor *v, void **obj, const char *kind, > @@ -91,5 +92,6 @@ void visit_type_size(Visitor *v, uint64_t *obj, const= char *name, Error **errp); > void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **= errp); > void visit_type_str(Visitor *v, char **obj, const char *name, Error **= errp); > void visit_type_number(Visitor *v, double *obj, const char *name, Erro= r **errp); > +void visit_type_freq(Visitor *v, int64_t *obj, const char *name, Error= **errp); > =20 > #endif > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 497eb9a..9ec0895 100644 > --- a/qapi/string-input-visitor.c > +++ b/qapi/string-input-visitor.c > @@ -110,6 +110,27 @@ static void parse_start_optional(Visitor *v, bool = *present, > *present =3D true; > } > =20 > +static void parse_type_freq(Visitor *v, int64_t *obj, const char *name= , > + Error **errp) Tiny glitch here, one space too much it seems. If you fix that: Acked-by: Andreas F=C3=A4rber > +{ > + StringInputVisitor *siv =3D DO_UPCAST(StringInputVisitor, visitor,= v); > + char *endp =3D (char *) siv->string; > + long long val; > + > + errno =3D 0; > + if (siv->string) { > + val =3D strtosz_suffix_unit(siv->string, &endp, > + STRTOSZ_DEFSUFFIX_B, 1000); Please also check here... > + } > + if (!siv->string || val =3D=3D -1 || *endp) { > + error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, > + "a value representable as a non-negative int64"); ...and here. > + return; > + } > + > + *obj =3D val; > +} > + > Visitor *string_input_get_visitor(StringInputVisitor *v) > { > return &v->visitor; > @@ -132,6 +153,7 @@ StringInputVisitor *string_input_visitor_new(const = char *str) > v->visitor.type_str =3D parse_type_str; > v->visitor.type_number =3D parse_type_number; > v->visitor.start_optional =3D parse_start_optional; > + v->visitor.type_freq =3D parse_type_freq; Optionally reorder this, so that it's alongside the other type_*? > =20 > v->string =3D str; > return v; >=20 Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg