From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1i1u-0003qW-Vi for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:09:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1i1t-0006Sy-Vs for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:09:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1i1t-0006Sr-MG for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:09:17 -0400 Message-ID: <502BE5C5.9010503@redhat.com> Date: Wed, 15 Aug 2012 12:09:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345053420-29974-1-git-send-email-mdroth@linux.vnet.ibm.com> <1345053420-29974-2-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1345053420-29974-2-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3C61DDF6A678A2005CAACD27" Subject: Re: [Qemu-devel] [PATCH for-1.2 v2 2/3] json-parser: don't replicate tokens at each level of recursion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@us.ibm.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3C61DDF6A678A2005CAACD27 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/15/2012 11:56 AM, Michael Roth wrote: > Currently, when parsing a stream of tokens we make a copy of the token > list at the beginning of each level of recursion so that we do not > modify the original list in cases where we need to fall back to an > earlier state. >=20 > + > +/* Note: parser_context_{peek|pop}_token do not increment the > + * token object's refcount. In both cases the references will continue= > + * to be * tracked and cleanup in parser_context_free() Bad comment reflow? s/be * tracked/be tracked/ > + > +/* to support error propagation, ctxt->err must be freed seperately */= s/seperately/separately/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3C61DDF6A678A2005CAACD27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQK+XGAAoJEKeha0olJ0NqQQQH/0dE3IO9opazecAfFCU8CVOZ qOiDqKuGVo3KM/m3TiMm97DotAGZex446sIqHsSeWGDcnOHrmhykGZ+NVkDsHLZA wGwwcwLDT9hwm4hCUUwyqZuTZg1iFEIWDbgpYropN8aKbFMTyXZKufJAU/GyY73L fFsOfzWRnYeG5S5iHs/nUops3Lsd9UUqvQr2Ghkhki8V+JcvwcoipL8AK6wLNxFV 04SSmLknvmFpB11XiXQQvNXyOhqrmk+fyamGUtvS98FH92ju5I7zHAwvjSUiNXyy U7c3LPfNYd6D95BNS9cWJQOotdEUjiPgcErcUuhHWp+ZIJ/jWGdZBx8/jlBbx+I= =q4bP -----END PGP SIGNATURE----- --------------enig3C61DDF6A678A2005CAACD27--