From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1ouQ-0000Pp-R1 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 21:30:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1ouO-0002xh-6q for qemu-devel@nongnu.org; Wed, 15 Aug 2012 21:30:02 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:59867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1ouN-0002xO-L6 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 21:30:00 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 Aug 2012 11:29:38 +1000 Message-ID: <502C4D06.5070706@linux.vnet.ibm.com> Date: Thu, 16 Aug 2012 09:29:42 +0800 From: Li Zhang MIME-Version: 1.0 References: <1344966575-25952-1-git-send-email-zhlcindy@linux.vnet.ibm.com> <1344966575-25952-2-git-send-email-zhlcindy@linux.vnet.ibm.com> <21561D9F-70C7-4DCB-86AD-6C844BA59981@suse.de> <502B3AF5.8010201@linux.vnet.ibm.com> <30B60976-E886-46D8-9798-23962C00B320@suse.de> In-Reply-To: <30B60976-E886-46D8-9798-23962C00B320@suse.de> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on sPAPR platform. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , Li Zhang , "david@gibson.dropbear.id.au" On 2012年08月15日 15:02, Alexander Graf wrote: > > On 15.08.2012, at 08:00, Li Zhang wrote: > >> On 2012年08月15日 02:09, Alexander Graf wrote: >>> On 14.08.2012, at 19:49, Li Zhang wrote: >>> >>>> USB is enabled as default on sPAPR platform because it needs >>>> USB keyboard and USB mouse when VGA is enabled. >>>> >>>> This patch is to add USB controller on sPAPR platform. >>>> >>>> Signed-off-by: Li Zhang >>> This looks a lot better than the first version :). >> Thanks. :) >>> Alex >>> >>>> --- >>>> hw/spapr.c | 5 +++++ >>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/hw/spapr.c b/hw/spapr.c >>>> index 81c9343..b45401b 100644 >>>> --- a/hw/spapr.c >>>> +++ b/hw/spapr.c >>>> @@ -710,6 +710,11 @@ static void ppc_spapr_init(ram_addr_t ram_size, >>>> spapr_vscsi_create(spapr->vio_bus); >>>> } >>>> >>>> + if (usb_enabled(true)) { >> Would you help replace "true" as "spapr->has_graphics" as your patch? >> We think it should be better to set the default as true when spapr->has_graphics. >> How do you think? > Yes, that's pretty much what I was asking for (here and for the mac99 u3 machine). Just base your patch on ppc-next. My patches are in there. That's great. Thanks a lot! > Alex > >>>> + pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus, >>>> + -1, "pci-ohci"); >>>> + } >>>> + >>>> if (rma_size < (MIN_RMA_SLOF << 20)) { >>>> fprintf(stderr, "qemu: pSeries SLOF firmware requires >= " >>>> "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF); >>>> -- >>>> 1.7.7.6 >>>> >> >> -- >> >> Li Zhang >> IBM China Linux Technology Centre >> -- Li Zhang IBM China Linux Technology Centre