From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1rom-0002sJ-AZ for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:36:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1roj-0006RC-T3 for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:36:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1roj-0006Qz-Kq for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:36:21 -0400 Message-ID: <502C78C0.8020508@redhat.com> Date: Wed, 15 Aug 2012 22:36:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <699332045f54bbea299eefd50f7198826e638170.1345016001.git.phrdina@redhat.com> In-Reply-To: <699332045f54bbea299eefd50f7198826e638170.1345016001.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6103F5FB3ACF729595177C5F" Subject: Re: [Qemu-devel] [PATCH 16/18] qapi: Convert info snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6103F5FB3ACF729595177C5F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/15/2012 01:41 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp.c | 33 +++++++++++++++++++++++++++++++++ > hmp.h | 1 + > monitor.c | 2 +- > qapi-schema.json | 34 ++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 30 ++++++++++++++++++++++++++++++ > savevm.c | 51 ++++++++++++++++++++++++------------------------= --- > sysemu.h | 2 -- > 7 files changed, 123 insertions(+), 30 deletions(-) >=20 > @@ -1053,6 +1053,40 @@ > { 'command': 'query-block-jobs', 'returns': ['BlockJobInfo'] } > =20 > ## > +# @SnapshotInfo: > +# We've got competition here: https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02961.html These two patches need to converge into a single design. > +# Snapshot list. This structure contains list of snapshots for virtua= l machine. > +# > +# @id: id of the snapshot. > +# > +# @tag: human readable tag of the snapshot. > +# > +# @vm_size: size of the snapshot in Bytes. As this is a new QMP command, you should use '-', not '_'. Benoit's patch named this @vm-state-size. > +# > +# @date: date and time of the snapshot as unix timestamp. > +# > +# @vm_clock: time in the guest in nsecs. For online internal snapshots (those created by savevm), the vm clock offset makes sense. But for offline snapshots (those created by 'qemu-img snapshot', with no VM state), there is no vm clock offset. 'qemu-img info' lists 00:00:00.000 as a result, but I wonder if it would be better to leave this field (and vm-state-size) as #optional and omit them from the JSON for offline snapshots. And since qemu refuses to load offline snapshots, it might be worth an additional field in the JSON that says whether a snapshot is online or offline, to make it easier for the parsing application to determine whether it can be loaded or must go through qemu-img while the guest is offline (then again, keeping vm-state-size as non-optional, and checking for 0 size, somewhat covers this). > +# > +# Since: 1.2 1.3 (entire series...) --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6103F5FB3ACF729595177C5F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQLHjAAAoJEKeha0olJ0NqjV8H/0h6QR5xzssSQPunAPYOkITY N/4py74XOqkAnHIHMWzst0yHTN/7qcW/mNZIFwbE+RkXHNwVcKZPLLMt+w88I4k/ wwhQaKC3tmu2IvSqYwTJ4xNkMESX9xKgfQUM75R1hVR87rDgeZ22HpTK1G2N/N0H C0DfZ+dbgbARq0gG+0IjnKl3FA55IPJhrD4zGs8pj7BfRwz8VwDmnu8l2O8JwHCR P2UoW3njSt0k+u+0emn3gS/KY2p/R59pHO9Esmc/17pZWjFqZtDtWLmPAu3gNM8P 4sdtYKs+Vg64cN8sL9/20rPlxIjUMc/gY2INqQkOLsQkmGSRCF+MWKB/r5ze3mo= =1WRL -----END PGP SIGNATURE----- --------------enig6103F5FB3ACF729595177C5F--