From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1rsA-0003x5-VG for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:39:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1rs9-0006u0-SS for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:39:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1rs9-0006tw-JD for qemu-devel@nongnu.org; Thu, 16 Aug 2012 00:39:53 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7G4dqNa002359 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Aug 2012 00:39:52 -0400 Message-ID: <502C7997.5040504@redhat.com> Date: Wed, 15 Aug 2012 22:39:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <46a2c15ae1bcd86a09bf979a624fd3e83a3b7626.1345016001.git.phrdina@redhat.com> In-Reply-To: <46a2c15ae1bcd86a09bf979a624fd3e83a3b7626.1345016001.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4CA9C7499764ECA3017E15D4" Subject: Re: [Qemu-devel] [PATCH 17/18] hmp: allow "bool" parameter to be optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4CA9C7499764ECA3017E15D4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/15/2012 01:41 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > monitor.c | 3 +++ > 1 file changed, 3 insertions(+) NACK. See patch 18 why I think you don't need this. >=20 > diff --git a/monitor.c b/monitor.c > index db9a8d0..a538e6a 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -3769,6 +3769,9 @@ static const mon_cmd_t *monitor_parse_command(Mon= itor *mon, > val =3D 1; > } else if (p - beg =3D=3D 3 && !memcmp(beg, "off", p -= beg)) { > val =3D 0; > + } else if (*typestr =3D=3D '?') { > + typestr++; > + break; > } else { > monitor_printf(mon, "Expected 'on' or 'off'\n"); > goto fail; >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4CA9C7499764ECA3017E15D4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQLHmXAAoJEKeha0olJ0NqLD0H/ArJUOtBHdiCkFVfT3UAkgAQ HcTOtXy0mPzWgPKsgJxSkZ6w2kXgAoQGbbGy9pTlu+DWhTT+SOBi3W6rP4gkGaLN qFU8HnebJv7+b2uVirKPqFtIHkRSq1LVkUjKKhNZ6Z7iV8x7X6rtpztzs/uuPiT0 e5/LQzDTgodAXWzifNiqa+5tkzvdml9V+Z84zXGImllqPjRrExaqGZk+fm+BTDk5 AsF2SQtHCQo0N2f8iVOTla33zMloiMmA24NqUf5hCiwYHD61968UbFxUZ9ktPG8l g7ML359gBKkjrJ4TU6Ul25v3Y7m0H7GajwxK8MkfmaLJrqB26Fgoel5T8CkeGhk= =UAq2 -----END PGP SIGNATURE----- --------------enig4CA9C7499764ECA3017E15D4--