From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1ycG-0005HX-BX
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:51:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1ycF-0000xb-37
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:51:56 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:47302)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1ycE-0000xP-Sh
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:51:55 -0400
Message-ID: <502CDECD.2000500@weilnetz.de>
Date: Thu, 16 Aug 2012 13:51:41 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1344519084-21847-1-git-send-email-armbru@redhat.com>
	<1344519084-21847-18-git-send-email-armbru@redhat.com>
In-Reply-To: <1344519084-21847-18-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/23] mips_malta mips_r4k: Suppress unused
 default drives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Am 09.08.2012 15:31, schrieb Markus Armbruster:
> Cc: Aurelien Jarno <aurelien@aurel32.net>
>
> Suppress default SD card drive for machines malta, mips.
>
> Suppress default floppy drive for machine mips.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   hw/mips_malta.c | 1 +
>   hw/mips_r4k.c   | 2 ++
>   2 files changed, 3 insertions(+)
>
> diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> index 351c88e..c1c52ac 100644
> --- a/hw/mips_malta.c
> +++ b/hw/mips_malta.c
> @@ -1019,6 +1019,7 @@ static QEMUMachine mips_malta_machine = {
>       .desc = "MIPS Malta Core LV",
>       .init = mips_malta_init,
>       .max_cpus = 16,
> +    .no_sdcard = 1,
>       .is_default = 1,
>   };
>   
> diff --git a/hw/mips_r4k.c b/hw/mips_r4k.c
> index 967a76e..d9f6dc5 100644
> --- a/hw/mips_r4k.c
> +++ b/hw/mips_r4k.c
> @@ -299,6 +299,8 @@ static QEMUMachine mips_machine = {
>       .name = "mips",
>       .desc = "mips r4k platform",
>       .init = mips_r4k_init,
> +    .no_floppy = 1,
> +    .no_sdcard = 1,
>   };
>   
>   static void mips_machine_init(void)

Reviewed-by: Stefan Weil <sw@weilnetz.de>

I'd prefer using 'true' instead of '1' (and changing the
variables to type bool), but that can be done later.

Regards,

Stefan W.