From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1yil-0007Gj-SV for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:58:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1yik-0002jO-SG for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:58:39 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:40243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1yik-0002j8-Lx for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:58:38 -0400 Message-ID: <502CE061.4020603@weilnetz.de> Date: Thu, 16 Aug 2012 13:58:25 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com> <20120813141658.1bc8b15e@doriath.home> <502B3CBD.9060709@weilnetz.de> <20120815135302.3c2cc4da@doriath.home> In-Reply-To: <20120815135302.3c2cc4da@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster , Alexander Graf , Eric Blake Am 15.08.2012 18:53, schrieb Luiz Capitulino: > On Wed, 15 Aug 2012 08:07:57 +0200 > Stefan Weil wrote: > >> Am 13.08.2012 19:16, schrieb Luiz Capitulino: >>> On Fri, 10 Aug 2012 11:04:08 -0500 >>> Anthony Liguori wrote: >>> >>>> This series implements the necessary commands to implements danpb's idea to >>>> remove -help parsing in libvirt. We would introduce all of these commands in >>>> 1.2 and then change the -help output starting in 1.3. >>> Applied to the qmp branch, thanks. >>> >> >> The series breaks cross compilation of QEMU for w32 on Debian Linux: >> >> LINK arm-softmmu/qemu-system-armw.exe >> ../qmp-marshal.o: In function `qmp_marshal_input_query_cpu_definitions': >> /home/stefan/w32/qmp-marshal.c:2585: undefined reference to >> `_qmp_query_cpu_definitions' > Does this patch fix it? > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02676.html Yes, Anthony's patch fixes that. I just noticed that he already applied it to git master. The solution which I had suggested below would have been much simpler. Using GCC_WEAK in the declaration worked for me with gcc from Debian Lenny, too. Which gcc requires different handling for w32 and non-w32? > Weak symbols obviously use a different name mangling, therefore > qmp_query_cpu_definitions is not found by the linker. > > Adding GCC_WEAK to the declaration of qmp_query_cpu_definitions in > generated file > qmp-commands.h fixes that. > > Regards, > > Stefan Weil >