Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

[Yonit Halperin <yhalperi@redhat.com>]

On 08/16/2012 12:42 PM, Gerd Hoffmann wrote:
> On 08/16/12 10:23, Yonit Halperin wrote:
>> Spice server needs to know about the vm state in order to prevent
>> attempts to write to devices when they are stopped, mainly during
>> the non-live stage of migration.
>
> Why this new hook?
>
> qemu already notifies spice-server using QXLWorker start/stop callbacks.
It notifies the QXLWorker, and it goes to the display_channel. Spice api 
changes anyway, by adding spice_server_set_seamless_migration, and as 
other channels need this notification as well, it would be nicer to 
explicitly notify the server about the vm start/stop and not abuse the 
QXLWorker notification. Another option would have been to add notifier 
for SpiceCharDeviceInterface as well, and then to any other new 
interface that will require it.

Regards,
Yonit.

>
> cheers,
>    Gerd
>
>