From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yhalperi@redhat.com>) id 1T1ziw-00015x-Fy
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:02:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yhalperi@redhat.com>) id 1T1zil-0006j5-Ri
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:02:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yhalperi@redhat.com>) id 1T1zil-0006it-JS
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:02:43 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7GD2g8c021215
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 16 Aug 2012 09:02:42 -0400
Message-ID: <502CEEDE.8010001@redhat.com>
Date: Thu, 16 Aug 2012 16:00:14 +0300
From: Yonit Halperin <yhalperi@redhat.com>
MIME-Version: 1.0
References: <1345105406-15082-1-git-send-email-yhalperi@redhat.com>
	<1345105406-15082-2-git-send-email-yhalperi@redhat.com>
	<502CC08B.3030602@redhat.com>
In-Reply-To: <502CC08B.3030602@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm
	start/stop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: mprivozn@redhat.com, qemu-devel@nongnu.org

On 08/16/2012 12:42 PM, Gerd Hoffmann wrote:
> On 08/16/12 10:23, Yonit Halperin wrote:
>> Spice server needs to know about the vm state in order to prevent
>> attempts to write to devices when they are stopped, mainly during
>> the non-live stage of migration.
>
> Why this new hook?
>
> qemu already notifies spice-server using QXLWorker start/stop callbacks.
It notifies the QXLWorker, and it goes to the display_channel. Spice api 
changes anyway, by adding spice_server_set_seamless_migration, and as 
other channels need this notification as well, it would be nicer to 
explicitly notify the server about the vm start/stop and not abuse the 
QXLWorker notification. Another option would have been to add notifier 
for SpiceCharDeviceInterface as well, and then to any other new 
interface that will require it.

Regards,
Yonit.

>
> cheers,
>    Gerd
>
>