From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1zs8-0004Fa-5h for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:12:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1zs3-0001Ra-V7 for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:12:24 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:46058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1zs3-0001RO-Qb for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:12:19 -0400 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 Aug 2012 09:12:17 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id A1B6C6E803A for ; Thu, 16 Aug 2012 09:12:14 -0400 (EDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7GDCD46119312 for ; Thu, 16 Aug 2012 09:12:14 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7GDBL5g021890 for ; Thu, 16 Aug 2012 07:11:21 -0600 Message-ID: <502CF177.3060007@linux.vnet.ibm.com> Date: Thu, 16 Aug 2012 09:11:19 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1345115718-4054-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1345115718-4054-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, patches@linaro.org On 08/16/2012 07:15 AM, Peter Maydell wrote: > Fix compilation failure on BSD systems (which don't have > O_DIRECT or O_NOATIME: > osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) > osdep.c:116: error: (Each undeclared identifier is reported only once > osdep.c:116: error: for each function it appears in.) > osdep.c:116: error: ‘O_NOATIME’ undeclared (first use in this function) > > Signed-off-by: Peter Maydell > --- > PS: Do we care about O_DSYNC, O_RSYNC, O_SYNC? POSIX says those can be > used via fcntl() too... Thanks very much Peter. The patch looks good to me. Could you point me to the reference you saw the fcntl description in? I didn't notice any flags mentioned here: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html The choice of flags was based on the Linux man page for fcntl() which says F_SETFL can change only the O_APPEND, O_ASYNC, O_DIRECT, O_NOATIME, and O_NONBLOCK flags. -- Regards, Corey