From: Gerd Hoffmann <kraxel@redhat.com>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: mprivozn@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop
Date: Thu, 16 Aug 2012 20:19:37 +0200 [thread overview]
Message-ID: <502D39B9.7030907@redhat.com> (raw)
In-Reply-To: <502CEEDE.8010001@redhat.com>
On 08/16/12 15:00, Yonit Halperin wrote:
> On 08/16/2012 12:42 PM, Gerd Hoffmann wrote:
>> On 08/16/12 10:23, Yonit Halperin wrote:
>>> Spice server needs to know about the vm state in order to prevent
>>> attempts to write to devices when they are stopped, mainly during
>>> the non-live stage of migration.
>>
>> Why this new hook?
>>
>> qemu already notifies spice-server using QXLWorker start/stop callbacks.
> It notifies the QXLWorker, and it goes to the display_channel. Spice api
> changes anyway, by adding spice_server_set_seamless_migration, and as
> other channels need this notification as well, it would be nicer to
> explicitly notify the server about the vm start/stop and not abuse the
> QXLWorker notification.
It is indeed cleaner API-wise. Is it possible to skip QXLWorker
notification when calling the new spice_server_vm_{start,stop} functions?
cheers,
Gerd
next prev parent reply other threads:[~2012-08-16 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 8:23 [Qemu-devel] [PATCH 0/4] add support for spice migration Yonit Halperin
2012-08-16 8:23 ` [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop Yonit Halperin
2012-08-16 9:42 ` Gerd Hoffmann
2012-08-16 13:00 ` Yonit Halperin
2012-08-16 18:19 ` Gerd Hoffmann [this message]
2012-08-16 8:23 ` [Qemu-devel] [PATCH 2/4] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED Yonit Halperin
2012-08-16 8:23 ` [Qemu-devel] [PATCH 3/4] spice: add 'migrated' flag to spice info Yonit Halperin
2012-08-16 8:23 ` [Qemu-devel] [PATCH 4/4] spice: adding seamless-migration option to the command line Yonit Halperin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D39B9.7030907@redhat.com \
--to=kraxel@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).