From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T24fW-0003s9-MD for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:19:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T24fV-0003zs-Os for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:19:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T24fV-0003zj-Ge for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:19:41 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7GIJein027897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Aug 2012 14:19:41 -0400 Message-ID: <502D39B9.7030907@redhat.com> Date: Thu, 16 Aug 2012 20:19:37 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1345105406-15082-1-git-send-email-yhalperi@redhat.com> <1345105406-15082-2-git-send-email-yhalperi@redhat.com> <502CC08B.3030602@redhat.com> <502CEEDE.8010001@redhat.com> In-Reply-To: <502CEEDE.8010001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: mprivozn@redhat.com, qemu-devel@nongnu.org On 08/16/12 15:00, Yonit Halperin wrote: > On 08/16/2012 12:42 PM, Gerd Hoffmann wrote: >> On 08/16/12 10:23, Yonit Halperin wrote: >>> Spice server needs to know about the vm state in order to prevent >>> attempts to write to devices when they are stopped, mainly during >>> the non-live stage of migration. >> >> Why this new hook? >> >> qemu already notifies spice-server using QXLWorker start/stop callbacks. > It notifies the QXLWorker, and it goes to the display_channel. Spice api > changes anyway, by adding spice_server_set_seamless_migration, and as > other channels need this notification as well, it would be nicer to > explicitly notify the server about the vm start/stop and not abuse the > QXLWorker notification. It is indeed cleaner API-wise. Is it possible to skip QXLWorker notification when calling the new spice_server_vm_{start,stop} functions? cheers, Gerd