From: Michael Tokarev <mjt@tls.msk.ru>
To: Iustin Pop <iusty@k1024.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: handle filenames with colons better
Date: Thu, 16 Aug 2012 23:24:11 +0400 [thread overview]
Message-ID: <502D48DB.20805@msgid.tls.msk.ru> (raw)
In-Reply-To: <20120816145836.GA6793@hq.k1024.org>
On 16.08.2012 18:58, Iustin Pop wrote:
> Commit 947995c (block: protect path_has_protocol from filenames with
> colons) introduced a way to handle filenames with colons based on
> whether the path contains a slash or not. IMHO this is not optimal,
> since we shouldn't rely on the contents of the path but rather on
> whether the given path exists as a file or not.
>
> As such, this patch tries to handle both files with and without
> slashes by falling back to opening them as files if no drivers
> supporting the protocol has been identified.
I for one dislike this idea entirely: I think there should be a
way to stop qemu from trying to open something as a file. It
opens a security hole after all, "what if" such a file will actually
exist?
If I can vote, I'm voting against this with both hands.
Thanks,
/mjt
next prev parent reply other threads:[~2012-08-16 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 14:58 [Qemu-devel] [PATCH] block: handle filenames with colons better Iustin Pop
2012-08-16 19:24 ` Michael Tokarev [this message]
2012-08-17 7:15 ` Iustin Pop
2012-08-17 7:56 ` Kevin Wolf
2012-08-17 10:05 ` Iustin Pop
2012-08-17 10:15 ` Kevin Wolf
2012-08-17 22:39 ` Iustin Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D48DB.20805@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=iusty@k1024.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).