From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2MnC-0007bE-KO for qemu-devel@nongnu.org; Fri, 17 Aug 2012 09:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2MnB-0006GM-Ce for qemu-devel@nongnu.org; Fri, 17 Aug 2012 09:40:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2MnB-0006G5-4b for qemu-devel@nongnu.org; Fri, 17 Aug 2012 09:40:49 -0400 Message-ID: <502E49D8.5010301@redhat.com> Date: Fri, 17 Aug 2012 15:40:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1337173681-25891-1-git-send-email-jim@meyering.net> <1337173681-25891-5-git-send-email-jim@meyering.net> <4FBA2033.4080002@redhat.com> <87ipch63z4.fsf@rho.meyering.net> In-Reply-To: <87ipch63z4.fsf@rho.meyering.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jim Meyering Cc: qemu-devel@nongnu.org, Anthony Liguori Am 17.08.2012 15:30, schrieb Jim Meyering: > Kevin Wolf wrote: >> Am 16.05.2012 15:07, schrieb Jim Meyering: >>> From: Jim Meyering >>> >>> Signed-off-by: Jim Meyering >> >> Acked-by: Kevin Wolf > > Hi Kevin, > > AFAICS, only one of these 6 patches has been applied. > From what I recall (it's been nearly 3mo), there was good > feedback and I posted at least one V2 patch. > For reference, here's the start of the series: > > http://marc.info/?l=qemu-devel&m=133717388221635&w=2 > > Let me know if there's anything I can do to help. Oh, that's bad. This series is spreads across several subsystems, so by acking the sheepdog patch (the only block layer one) I was intending to signal that I'm okay with merging it, but that I expect a "global maintainer" to actually commit it. Did all your other series get merged? There were a lot more patches with small fixes and I can't see them in git master at all. I seem to remember that they got delayed because you posted them late during the last freeze, but obviously they should have been long committed now. Anthony, what happened with these series? I think it makes sense to pull them into -rc1 because all of them were bug fixes, even though mostly minor ones. Kevin > Jim Meyering (5): > qemu-ga: don't leak a file descriptor upon failed lockf > linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure > sheepdog: don't leak socket file descriptor upon connection failure > arm-semi: don't leak 1KB user string lock buffer upon TARGET_SYS_OPEN > softmmu-semi: fix lock_user* functions not to deref NULL upon OOM > > block/sheepdog.c | 1 + > linux-user/syscall.c | 4 ++-- > qemu-ga.c | 3 +++ > softmmu-semi.h | 5 ++++- > target-arm/arm-semi.c | 13 +++++++------ > 5 files changed, 17 insertions(+), 9 deletions(-) >