From: "Andreas Färber" <afaerber@suse.de>
To: Jim Meyering <jim@meyering.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 2/2] envlist.c: handle strdup failure
Date: Fri, 17 Aug 2012 18:08:09 +0200 [thread overview]
Message-ID: <502E6C69.4090802@suse.de> (raw)
In-Reply-To: <874no14jo5.fsf@rho.meyering.net>
Am 17.08.2012 17:34, schrieb Jim Meyering:
> Andreas Färber wrote:
>
>> Am 17.08.2012 15:35, schrieb Jim Meyering:
>>> Jim Meyering wrote:
>>>> From: Jim Meyering <meyering@redhat.com>
>>>>
>>>> Without this, envlist_to_environ may silently fail to copy all
>>>> strings into the destination buffer, and both callers would leak
>>>> any env strings allocated after a failing strdup, because the
>>>> freeing code stops at the first NULL pointer.
>>>>
>>>> Signed-off-by: Jim Meyering <meyering@redhat.com>
>>>> ---
>>>> envlist.c | 12 ++++++++++--
>>>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/envlist.c b/envlist.c
>>>> index be0addb..7532091 100644
>>>> --- a/envlist.c
>>>> +++ b/envlist.c
>>>> @@ -234,8 +234,16 @@ envlist_to_environ(const envlist_t *envlist, size_t *count)
>>>> return (NULL);
>>>>
>>>> for (entry = envlist->el_entries.lh_first; entry != NULL;
>>>> - entry = entry->ev_link.le_next) {
>>>> - *(penv++) = strdup(entry->ev_var);
>>>> + entry = entry->ev_link.le_next, penv++) {
>>>> + *penv = strdup(entry->ev_var);
>>>> + if (*penv == NULL) {
>>>> + char **e = env;
>>>> + while (e <= penv) {
>>>> + free(*e++);
>>>> + }
>>>> + free(env);
>>>> + return NULL;
>>>> + }
>>>> }
>>>> *penv = NULL; /* NULL terminate the list */
>>>
>>> It seems this has been lost in this list's high volume of patches.
>>> Anyone interested? Repost desired?
>>
>> You announced a v3 but replied to v2?
>
> Here are links to v3:
>
> [PATCHv3 1/2] envlist.c: convert each TAB(width-4) to equivalent spaces
> https://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02967.html
>
> [Qemu-devel] [PATCHv3 2/2] envlist.c: handle strdup failure
> https://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02966.html
I commented on v3. For practical reasons please ping the latest patches
and prefer Patchwork links so that no <address@hidden> gets committed by
accident.
Thanks for your efforts in reviewing and fixing all these issues!
Andreas
>
>> Indentation looks odd in 2/2, too.
>
> That was fixed in v3.
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-08-17 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 9:50 [Qemu-devel] [PATCHv2 0/2] envlist.c: handle strdup failure Jim Meyering
2012-05-22 9:50 ` [Qemu-devel] [PATCHv2 1/2] envlist.c: convert all TABs to equivalent spaces Jim Meyering
2012-05-22 9:55 ` Peter Maydell
2012-05-22 10:17 ` Jim Meyering
2012-05-22 9:50 ` [Qemu-devel] [PATCHv2 2/2] envlist.c: handle strdup failure Jim Meyering
2012-08-17 13:35 ` Jim Meyering
2012-08-17 15:10 ` Andreas Färber
2012-08-17 15:34 ` Jim Meyering
2012-08-17 16:08 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502E6C69.4090802@suse.de \
--to=afaerber@suse.de \
--cc=jim@meyering.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).