From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1T2PIK-0000s3-6e
	for qemu-devel@nongnu.org; Fri, 17 Aug 2012 12:21:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1T2PII-0003cG-Sl
	for qemu-devel@nongnu.org; Fri, 17 Aug 2012 12:21:08 -0400
Message-ID: <502E6F48.2050108@web.de>
Date: Fri, 17 Aug 2012 18:20:24 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <502E236C.6090508@siemens.com>
In-Reply-To: <502E236C.6090508@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RESEND][PATCH for-1.2] i82378: Remove bogus MMIO
 coalescing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>, =?ISO-8859-1?Q?Herv=E9_Pouss?= =?ISO-8859-1?Q?ineau?= <hpoussin@reactos.org>, qemu-devel <qemu-devel@nongnu.org>, qemu-stable@nongnu.org

Am 17.08.2012 12:56, schrieb Jan Kiszka:
> This MMIO area is an entry gate to legacy PC ISA devices, addressed via
> PIO over there. Quite a few of the PIO ports have side effects on access
> like starting/stopping timers that must be executed properly ordered
> /wrt the CPU. So we have to remove the coalescing mark.
> 
> Acked-by: Hervé Poussineau <hpoussin@reactos.org>

(I would expect this to go under the SoB, documenting the chronological
order...)

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

I had consented to this fix and expected it to go in alongside the
series this came in (kvm/uq-master?).

Anthony, do you want a prep PULL for this now? Otherwise explicitly:

Acked-by: Andreas Färber <andreas.faerber@web.de>

Regards,
Andreas

> ---
>  hw/i82378.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/i82378.c b/hw/i82378.c
> index 9b11d90..2123c14 100644
> --- a/hw/i82378.c
> +++ b/hw/i82378.c
> @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev)
>      pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io);
>  
>      memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000);
> -    memory_region_set_coalescing(&s->mem);
>      pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem);
>  
>      /* Make I/O address read only */
>