From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2ig6-0005UO-Gd for qemu-devel@nongnu.org; Sat, 18 Aug 2012 09:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2ig5-00016B-Dc for qemu-devel@nongnu.org; Sat, 18 Aug 2012 09:02:58 -0400 Received: from qmta03.emeryville.ca.mail.comcast.net ([76.96.30.32]:43294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2ig5-000165-45 for qemu-devel@nongnu.org; Sat, 18 Aug 2012 09:02:57 -0400 Message-ID: <502F927A.8060709@redhat.com> Date: Sat, 18 Aug 2012 07:02:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345288635-1369-1-git-send-email-quintela@redhat.com> <1345288635-1369-4-git-send-email-quintela@redhat.com> In-Reply-To: <1345288635-1369-4-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2E03DD586ADEDAAC142E63E4" Subject: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2E03DD586ADEDAAC142E63E4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/18/2012 05:17 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hmp.c | 4 ++-- > migration.c | 6 +++--- > qapi-schema.json | 14 +++++++------- > qmp-commands.hx | 6 +++--- > 4 files changed, 15 insertions(+), 15 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -290,10 +290,6 @@ > # > # @total: total amount of bytes involved in the migration process > # > -# @total-time: total amount of ms since migration started. If > -# migration has ended, it returns the total migration > -# time. (since 1.2) > -# > # @duplicate: number of duplicate pages (since 1.2) > # > # @normal : number of normal pages (since 1.2) > @@ -304,8 +300,7 @@ > ## > { 'type': 'MigrationStats', > 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , > - 'total-time': 'int', 'duplicate': 'int', 'normal': 'int', > - 'normal-bytes': 'int' } } > + 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' = } } >=20 > ## > # @XBZRLECacheStats > @@ -350,12 +345,17 @@ > # migration statistics, only returned if XBZRLE feature= is on and > # status is 'active' or 'completed' (since 1.2) > # > +# @total-time: total amount of milliseconds since migration started. > +# If migration has ended, it returns the total migration > +# time. (since 1.2) > +# > # Since: 0.14.0 > ## > { 'type': 'MigrationInfo', > 'data': {'*status': 'str', '*ram': 'MigrationStats', > '*disk': 'MigrationStats', > - '*xbzrle-cache': 'XBZRLECacheStats'} } > + '*xbzrle-cache': 'XBZRLECacheStats', > + 'total-time': 'int'} } Anthony - are you planning on taking this series for 1.2? If we don't get this patch in on time, then taking this for 1.3 would result in changing released QMP interface (right now, there has been no release with the field in the wrong type). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2E03DD586ADEDAAC142E63E4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQL5J8AAoJEKeha0olJ0NqzpUIAIrhYWHnmHFmh4CWG5tHspQ1 riSqMZQ0EpngBx881ITVxMbQQgm0UpWwG3MNwjzDWXXL/2Ll6ePhVaLImMVkxWMC uZG/YB+lPkVDMiKl58v1idpsk/c+NSAFxsvccJhK2t/GUa+g+7B8rFK0dEMWNjtA 6hvuWVXTNbwmB/IXqdQORQRawX9MWCEESKrgjXoEl/83D0dAPLacYbDi1Bdw/iMf OXNY7wtZnX6HZFtvWsolwBjUQfJ9mcCWjzGjOvJaCEvnUKnzGVK+qi/6wGv30ucm Wzjz828m4pW6AD+arxUWSjXauvQ0igiKprR8bug8rsOO41Jclc+pUDqhRCRZvkk= =8W3A -----END PGP SIGNATURE----- --------------enig2E03DD586ADEDAAC142E63E4--