From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
lf-virt <virtualization@lists.linux-foundation.org>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
target-devel <target-devel@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>, Zhi Yong Wu <wuzhy@cn.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition
Date: Sat, 18 Aug 2012 20:52:56 +0200 [thread overview]
Message-ID: <502FE488.3000303@redhat.com> (raw)
In-Reply-To: <1344975625.22433.88.camel@haakon2.linux-iscsi.org>
Il 14/08/2012 22:20, Nicholas A. Bellinger ha scritto:
>>> > > Since virtio_scsi currently assumes a single vqs for data, this patch
>>> > > simply changes ->cmd_vqs[1] to handle the single VirtQueue.
Wrong, multiqueue works just fine. :) It's just the kernel driver that
doesn't support it yet.
>>> > > Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> > > Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>>> > > Cc: Michael S. Tsirkin <mst@redhat.com>
>>> > > Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
>> >
>> > This is a bugfix we need even without vhost, right?
>> >
> I believe so, as it appears to be stomping past the end of memory for
> every virtio-scsi initialization regardless of vhost usage..
You just did a wrong merge. When commit d2ad7dd (virtio-scsi: add
multiqueue capability, 2012-04-06) changed cmd_vq from pointer to array
of pointers, you should have moved the following fields to the middle of
the struct, just like that commit did.
Paolo
next prev parent reply other threads:[~2012-08-18 18:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 8:35 [Qemu-devel] [RFC-v2 0/6] vhost-scsi: Add support for host virtualized target Nicholas A. Bellinger
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection Nicholas A. Bellinger
2012-08-13 8:51 ` Michael S. Tsirkin
2012-08-13 12:06 ` Jan Kiszka
2012-08-13 18:03 ` Michael S. Tsirkin
2012-08-13 18:06 ` Jan Kiszka
2012-08-13 18:17 ` Michael S. Tsirkin
2012-08-14 20:10 ` Nicholas A. Bellinger
2012-08-13 19:39 ` Blue Swirl
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 2/6] vhost: Pass device path to vhost_dev_init() Nicholas A. Bellinger
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost Nicholas A. Bellinger
2012-08-13 8:53 ` Michael S. Tsirkin
2012-08-14 20:31 ` Nicholas A. Bellinger
2012-08-18 19:12 ` Michael S. Tsirkin
2012-08-19 0:36 ` Nicholas A. Bellinger
2012-08-19 8:44 ` Michael S. Tsirkin
2012-08-20 22:24 ` Nicholas A. Bellinger
2012-08-13 8:59 ` Michael S. Tsirkin
2012-08-14 21:12 ` Nicholas A. Bellinger
2012-08-18 19:10 ` Michael S. Tsirkin
2012-08-18 23:38 ` Nicholas A. Bellinger
2012-08-13 19:47 ` Blue Swirl
2012-08-14 21:17 ` Nicholas A. Bellinger
2012-08-20 9:02 ` Paolo Bonzini
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi Nicholas A. Bellinger
2012-08-20 9:04 ` Paolo Bonzini
2012-08-20 11:31 ` Stefan Hajnoczi
2012-08-20 11:57 ` Michael S. Tsirkin
2012-08-20 12:00 ` Paolo Bonzini
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 5/6] virtio-scsi: Set max_target=0 during vhost-scsi operation Nicholas A. Bellinger
2012-08-13 8:35 ` [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition Nicholas A. Bellinger
2012-08-13 9:02 ` Michael S. Tsirkin
2012-08-14 20:20 ` Nicholas A. Bellinger
2012-08-18 18:52 ` Paolo Bonzini [this message]
2012-08-18 21:47 ` Nicholas A. Bellinger
2012-08-13 9:04 ` [Qemu-devel] [RFC-v2 0/6] vhost-scsi: Add support for host virtualized target Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502FE488.3000303@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).