From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2oCl-0003Np-Qm for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:57:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2oCk-0003Q0-SL for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:57:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2oCk-0003Pq-Ku for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:57:02 -0400 Message-ID: <502FE56F.9010708@redhat.com> Date: Sat, 18 Aug 2012 20:56:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344264970-25242-1-git-send-email-pbonzini@redhat.com> <502780BB.4000903@msgid.tls.msk.ru> In-Reply-To: <502780BB.4000903@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: fix vhost handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , avi@redhat.com Il 12/08/2012 12:08, Michael Tokarev ha scritto: >> > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net >> > because it always registers the virtio_pci_host_notifier_read() handler >> > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. >> > The result is both QEMU and vhost_net.ko polling on the same eventfd >> > and the virtio_net.ko guest driver seeing inconsistent results: >> > >> > # ifconfig eth0 192.168.0.1 netmask 255.255.255.0 >> > virtio_net virtio0: output:id 0 is not a head! >> > >> > To fix this, proceed the same as we do for irqfd: add a parameter to >> > virtio_queue_set_host_notifier_fd_handler and in that case only set >> > the notifier, not the handler. > Stable-1.1 material? The mentioned commit is included into 1.1 release. Are you sure? Paolo