From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2r1H-0005LV-5O for qemu-devel@nongnu.org; Sat, 18 Aug 2012 17:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2r1G-0000ic-BY for qemu-devel@nongnu.org; Sat, 18 Aug 2012 17:57:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2r1G-0000iU-3K for qemu-devel@nongnu.org; Sat, 18 Aug 2012 17:57:22 -0400 Message-ID: <50300FBC.4010206@redhat.com> Date: Sat, 18 Aug 2012 23:57:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345170981-7738-1-git-send-email-ronniesahlberg@gmail.com> <1345170981-7738-2-git-send-email-ronniesahlberg@gmail.com> In-Reply-To: <1345170981-7738-2-git-send-email-ronniesahlberg@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] ISCSI: Set number of blocks to 0 for blank CDROM devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ronnie Sahlberg Cc: kwolf@redhat.com, qemu-devel@nongnu.org Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: > The number of blocks of the device is used to compute the device size > in bdrv_getlength()/iscsi_getlength(). > For MMC devices, the ReturnedLogicalBlockAddress in the READCAPACITY10 > has a special meaning when it is 0. > In this case it does not mean that LBA 0 is the last accessible LBA, > and thus the device has 1 readable block, but instead it means that the > disc is blank and there are no readable blocks. > > This change ensures that when the iSCSI LUN is loaded with a blank > DVD-R disk or similar that bdrv_getlength() will return the correct > size of the device as 0 bytes. > > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index bb9cf82..fb420ea 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -717,7 +717,12 @@ iscsi_readcapacity10_cb(struct iscsi_context *iscsi, int status, > } > > itask->iscsilun->block_size = rc10->block_size; > - itask->iscsilun->num_blocks = rc10->lba + 1; > + if (rc10->lba == 0) { > + /* blank disk loaded */ > + itask->iscsilun->num_blocks = 0; > + } else { > + itask->iscsilun->num_blocks = rc10->lba + 1; > + } > itask->bs->total_sectors = itask->iscsilun->num_blocks * > itask->iscsilun->block_size / BDRV_SECTOR_SIZE ; > > Thanks, applied to SCSI branch. We'll see whether this hits 1.2. Paolo