From: Paolo Bonzini <pbonzini@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks
Date: Sun, 19 Aug 2012 00:16:17 +0200 [thread overview]
Message-ID: <50301431.6090904@redhat.com> (raw)
In-Reply-To: <CAN05THTvHt1FDKPs6Z1+bQngbSbO=MDkORtc6z9WHwNozG-NAQ@mail.gmail.com>
Il 19/08/2012 00:02, ronnie sahlberg ha scritto:
> Neither of them work, basically because in
> block.c:find_image_format()
>
> if bs->sg is not set in
>
> if (bs->sg || !bdrv_is_inserted(bs)) {
>
> then we continue to
>
> ret = bdrv_pread(bs, 0, buf, sizeof(buf));
>
> which fails with an error.
> So this patch is basically to prevent find_image_format() from trying
> to read from a blank disk.
>
> Maybe there is a better way to do this?
Yeah, I think in this case find_image_format should just use raw.
Paolo
next prev parent reply other threads:[~2012-08-18 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 2:36 [Qemu-devel] [PATCH] Two trivial patches for iSCSI and blank DVDs Ronnie Sahlberg
2012-08-17 2:36 ` [Qemu-devel] [PATCH 1/2] ISCSI: Set number of blocks to 0 for blank CDROM devices Ronnie Sahlberg
2012-08-18 21:57 ` Paolo Bonzini
2012-08-18 22:06 ` ronnie sahlberg
2012-08-17 2:36 ` [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks Ronnie Sahlberg
2012-08-18 14:23 ` Blue Swirl
2012-08-18 21:58 ` Paolo Bonzini
2012-08-18 22:02 ` ronnie sahlberg
2012-08-18 22:04 ` ronnie sahlberg
2012-08-18 22:16 ` Paolo Bonzini [this message]
2012-08-18 22:19 ` ronnie sahlberg
2012-08-18 22:41 ` Paolo Bonzini
2012-08-18 22:20 ` Paolo Bonzini
2012-08-18 23:44 ` ronnie sahlberg
2012-08-19 10:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50301431.6090904@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).