qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
Date: Mon, 20 Aug 2012 08:07:08 +0200	[thread overview]
Message-ID: <5031D40C.8010602@redhat.com> (raw)
In-Reply-To: <20120818161524.GI8135@garlic.redhat.com>

  Hi,

>>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
>>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
>>
>> Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> 
> So you are telling me to undo a change that Gerd asked for - could you
> please at least debate about the merits of both approaches? the point of
> having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to allow
> usage of #if without defined, which is shorter.

Hmm?  That wasn't that I meant, must have been a tyops.
I mean you should just do ...

#ifndef QXL_IO_MONITORS_CONFIG_ASYNC            <--- without *_HAS_*
#define QXL_IO_MONITORS_CONFIG_ASYNC $value
#endif

then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
#ifdefs) at all ...

cheers,
  Gerd

  parent reply	other threads:[~2012-08-20  6:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 11:50 [Qemu-devel] [PATCH v5 1.2 queue 0/4] QXL_IO_MONITORS_CONFIG_ASYNC + misc Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 1/4] qxl/update_area_io: guest_bug on invalid parameters Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-08-17 12:38   ` [Qemu-devel] [PATCH v6 1.2] " Alon Levy
2012-08-17 15:39   ` [Qemu-devel] [PATCH v7 " Alon Levy
2012-08-18 14:31     ` Blue Swirl
2012-08-18 16:16       ` Alon Levy
2012-08-18 19:07         ` Blue Swirl
2012-08-20  8:56           ` Alon Levy
2012-08-20  6:07         ` Gerd Hoffmann [this message]
2012-08-20  8:00           ` Alon Levy
2012-08-20  8:20             ` Alon Levy
2012-08-20  8:32             ` Gerd Hoffmann
2012-08-20  8:48               ` Alon Levy
2012-08-20  9:02                 ` Gerd Hoffmann
2012-08-20  9:37                   ` Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5031D40C.8010602@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).