From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3L8s-0002fr-EM for qemu-devel@nongnu.org; Mon, 20 Aug 2012 02:07:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3L8r-0007gy-Dt for qemu-devel@nongnu.org; Mon, 20 Aug 2012 02:07:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3L8r-0007gs-6A for qemu-devel@nongnu.org; Mon, 20 Aug 2012 02:07:13 -0400 Message-ID: <5031D40C.8010602@redhat.com> Date: Mon, 20 Aug 2012 08:07:08 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1345204252-8205-4-git-send-email-alevy@redhat.com> <1345217997-21965-1-git-send-email-alevy@redhat.com> <20120818161524.GI8135@garlic.redhat.com> In-Reply-To: <20120818161524.GI8135@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: Blue Swirl , qemu-devel@nongnu.org Hi, >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 >> >> Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > So you are telling me to undo a change that Gerd asked for - could you > please at least debate about the merits of both approaches? the point of > having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to allow > usage of #if without defined, which is shorter. Hmm? That wasn't that I meant, must have been a tyops. I mean you should just do ... #ifndef QXL_IO_MONITORS_CONFIG_ASYNC <--- without *_HAS_* #define QXL_IO_MONITORS_CONFIG_ASYNC $value #endif then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the #ifdefs) at all ... cheers, Gerd