From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
Date: Mon, 20 Aug 2012 11:02:48 +0200 [thread overview]
Message-ID: <5031FD38.3050608@redhat.com> (raw)
In-Reply-To: <1102887745.16546679.1345452511180.JavaMail.root@redhat.com>
Hi,
>> Maybe revisit upstream spice packaging? spice internal usage of
>> spice-protocol is handled via submodules now. Are there external
>> users, other than qemu? Does it make sense to keep the
>> spice-server / spice-protocol split in the first place? Or should
>> spice-server just provide the protocol headers too?
>
> spice-server is a much larger project then spice-protocol. The agents
> and the drivers don't need any bits in spice-server.
I didn't meant to kill the spice-protocol git repo, just the way it is
distributed.
Remove any makefiles & stuff from spice-protocol, so it is really just
the headers. Any spice-internal users get it as submodule like they do
today. spice-server gets updated to also install the spice-protocol
header files from the submodule.
Kills the whole protocol header version dance for the external users
(the submodule usage already does it for the internal ones). When
you've installed spice-server-devel you automatically also have recent
enougth spice protocol headers installed.
> Sure, we can
> unify them - it would make it easier for qemu and Xspice (the only
> other external user).
So both external users need the spice server too. So I think it makes
sense to have spice-server ship the protocol headers.
cheers,
Gerd
next prev parent reply other threads:[~2012-08-20 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 11:50 [Qemu-devel] [PATCH v5 1.2 queue 0/4] QXL_IO_MONITORS_CONFIG_ASYNC + misc Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 1/4] qxl/update_area_io: guest_bug on invalid parameters Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-08-17 12:38 ` [Qemu-devel] [PATCH v6 1.2] " Alon Levy
2012-08-17 15:39 ` [Qemu-devel] [PATCH v7 " Alon Levy
2012-08-18 14:31 ` Blue Swirl
2012-08-18 16:16 ` Alon Levy
2012-08-18 19:07 ` Blue Swirl
2012-08-20 8:56 ` Alon Levy
2012-08-20 6:07 ` Gerd Hoffmann
2012-08-20 8:00 ` Alon Levy
2012-08-20 8:20 ` Alon Levy
2012-08-20 8:32 ` Gerd Hoffmann
2012-08-20 8:48 ` Alon Levy
2012-08-20 9:02 ` Gerd Hoffmann [this message]
2012-08-20 9:37 ` Alon Levy
2012-08-17 11:50 ` [Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5031FD38.3050608@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).