From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Nst-0005VU-9W for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:02:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Nsp-0007PA-C6 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:02:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Nsp-0007Ot-4G for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:02:51 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7K92o9c002208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Aug 2012 05:02:50 -0400 Message-ID: <5031FD38.3050608@redhat.com> Date: Mon, 20 Aug 2012 11:02:48 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1102887745.16546679.1345452511180.JavaMail.root@redhat.com> In-Reply-To: <1102887745.16546679.1345452511180.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, >> Maybe revisit upstream spice packaging? spice internal usage of >> spice-protocol is handled via submodules now. Are there external >> users, other than qemu? Does it make sense to keep the >> spice-server / spice-protocol split in the first place? Or should >> spice-server just provide the protocol headers too? > > spice-server is a much larger project then spice-protocol. The agents > and the drivers don't need any bits in spice-server. I didn't meant to kill the spice-protocol git repo, just the way it is distributed. Remove any makefiles & stuff from spice-protocol, so it is really just the headers. Any spice-internal users get it as submodule like they do today. spice-server gets updated to also install the spice-protocol header files from the submodule. Kills the whole protocol header version dance for the external users (the submodule usage already does it for the internal ones). When you've installed spice-server-devel you automatically also have recent enougth spice protocol headers installed. > Sure, we can > unify them - it would make it easier for qemu and Xspice (the only > other external user). So both external users need the spice server too. So I think it makes sense to have spice-server ship the protocol headers. cheers, Gerd