From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3PNn-0005Bq-IB
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 06:38:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3PNm-0000O5-BA
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 06:38:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12688)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3PNm-0000Nx-2m
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 06:38:54 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7KAcrhS006364
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 20 Aug 2012 06:38:53 -0400
Message-ID: <503213BB.5030106@redhat.com>
Date: Mon, 20 Aug 2012 12:38:51 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1345455158-15617-1-git-send-email-alevy@redhat.com>
	<1345455158-15617-3-git-send-email-alevy@redhat.com>
In-Reply-To: <1345455158-15617-3-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v8 3/4] qxl: add
	QXL_IO_MONITORS_CONFIG_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

Patch looks alot nicer now with a bunch if #ifdefs removed.

One issue left I missed before:

>      case QXL_MODE_COMPAT:
>          /* note: no need to call qxl_create_memslots, qxl_set_mode
> @@ -2065,6 +2124,7 @@ static VMStateDescription qxl_vmstate = {
>          VMSTATE_ARRAY(guest_surfaces.cmds, PCIQXLDevice, NUM_SURFACES, 0,
>                        vmstate_info_uint64, uint64_t),
>          VMSTATE_UINT64(guest_cursor, PCIQXLDevice),
> +        VMSTATE_UINT64(guest_monitors_config, PCIQXLDevice),
>          VMSTATE_END_OF_LIST()
>      },

That breaks migration.

You probably want a subsection here which stuffs guest_monitors_config
into the stream only in case the guest has actually configured it, so
migration between qemu versions with & without monitor config support
keeps working as long as the guest doesn't use the new feature (or it is
disabled via rev=3).

cheers,
  Gerd